Re: Review Request 70208: Added test for reconciliation of multiple operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70208/#review213719 --- PASS: Mesos patch 70208 was successfully built and tested.

Re: Review Request 70129: Updated advanced contributing guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70129/#review213717 --- PASS: Mesos patch 70129 was successfully built and tested.

Re: Review Request 69582: Added a test to verify a bug fix for the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69582/#review213715 --- PASS: Mesos patch 69582 was successfully built and tested.

Re: Review Request 70158: WIP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70158/#review213714 --- PASS: Mesos patch 70158 was successfully built and tested.

Re: Review Request 70200: Changed operation reconciliation to send updates on the event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70200/#review213712 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 70206: Displayed error message on resource validation failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70206/#review213711 --- PASS: Mesos patch 70206 was successfully built and tested.

Re: Review Request 70200: Changed operation reconciliation to send updates on the event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70200/ --- (Updated March 14, 2019, 1:41 a.m.) Review request for mesos, Benjamin

Review Request 70208: Added test for reconciliation of multiple operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70208/ --- Review request for mesos, Gastón Kleiman, Joseph Wu, Megha Sharma, and Jiang

Re: Review Request 70203: Updated a test for `UPDATE_QUOTA` call validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70203/#review213710 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68508: Added tracking of framework allocations in the allocator Slave class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68508/#review213709 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 67044: Renamed a method in the master metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67044/#review213707 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 66344: Supported non-speculative operations on agent default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66344/#review213708 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 70158: WIP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70158/#review213706 --- PASS: Mesos patch 70158 was successfully built and tested.

Re: Review Request 69582: Added a test to verify a bug fix for the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69582/#review213705 --- PASS: Mesos patch 69582 was successfully built and tested.

Re: Review Request 70129: Updated advanced contributing guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70129/#review213704 --- PASS: Mesos patch 70129 was successfully built and tested.

Re: Review Request 68916: Moved libevent_openssl validation into libevent.m4.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68916/#review213702 --- FAIL: Failed to apply the dependent review: 68904. Failed

Re: Review Request 70165: Fixed operator operation handling with resource provider resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70165/#review213701 --- PASS: Mesos patch 70165 was successfully built and tested.

Re: Review Request 68736: Added `task cat` command to new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68736/#review213700 --- FAIL: Failed to apply the dependent review: 68711. Failed

Re: Review Request 70201: Added a method to check `ResourceLimits::contains(ResourceQuantities)`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70201/#review213699 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66881: Added benchmark test for master metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66881/#review213698 --- FAIL: Failed to apply the dependent review: 66845. Failed

Re: Review Request 68123: Avoided unnecessary `Resources::allocations()` call in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68123/#review213697 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 70200: Changed operation reconciliation to send updates on the event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70200/#review213696 --- Patch looks great! Reviews applied: [70200] Passed command:

Re: Review Request 70084: Avoid dereferencing removed executors and launching containers for them.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70084/#review213695 --- PASS: Mesos patch 70084 was successfully built and tested.

Re: Review Request 67177: Sorted container mounts by their target paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67177/#review213694 --- FAIL: Failed to apply the dependent review: 67175. Failed

Re: Review Request 65847: Fixed allocator test `QuotaAbsentFramework`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65847/#review213693 --- FAIL: Failed to apply the dependent review: 65819. Failed

Re: Review Request 70200: Changed operation reconciliation to send updates on the event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70200/#review213691 --- src/master/master.cpp Line 9557 (original), 9557-9564 (patched)

Re: Review Request 69615: Disable containerizer ptrace attach.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69615/#review213692 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 70169: Refactored SLRP to use `ServiceManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70169/#review213690 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69955: Added SLRP unit tests for destroying unpublished persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69955/#review213689 --- PASS: Mesos patch 69955 was successfully built and tested.

Re: Review Request 70133: Removed unnecessary accept filters in SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70133/#review213688 --- PASS: Mesos patch 70133 was successfully built and tested.

Re: Review Request 54987: Updated `docs/monitoring/md` for new agent event queue metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54987/#review213687 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 68301: Changed `DEFAULT_EXECUTOR_INFO` to use `default:id`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68301/#review213686 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 70117: Added unit tests for offer operation feedback metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70117/#review213685 --- Patch looks great! Reviews applied: [70115, 70156, 70185, 70116,

Re: Review Request 69313: Enabled parallel test runner to cmake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69313/#review213684 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 70202: Added call handler for `UPDATE_QUOTA`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70202/#review213683 --- Fix it, then Ship it! src/master/master.hpp Lines 1169

Re: Review Request 70201: Added a method to check `ResourceLimits::contains(ResourceQuantities)`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70201/#review213682 --- Ship it! src/common/resource_quantities.cpp Lines 406-418

Re: Review Request 70203: Updated a test for `UPDATE_QUOTA` call validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70203/#review213681 --- Ship it! Nice! src/tests/master_validation_tests.cpp Lines

Re: Review Request 70161: Added validation for `QuotaConfig`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70161/#review213680 --- Ship it! src/master/quota.cpp Lines 323-349 (patched)

Re: Review Request 70151: Added `class ResourceLimits`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70151/#review213676 --- Looks like a bug was introduced? See below

Re: Review Request 70053: Used std::string as buffer instead of manually managed dynamic array.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70053/#review213679 --- PASS: Mesos patch 70053 was successfully built and tested.

Re: Review Request 70184: Fixed flakiness in 'RetryRpcWithExponentialBackoff'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70184/#review213678 --- PASS: Mesos patch 70184 was successfully built and tested.

Re: Review Request 70160: Added `<<` operator to `protobuf::Map`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70160/#review213677 --- Ship it! Ship It! - Benjamin Mahler On March 8, 2019, 7:22

Re: Review Request 70149: Added a `contains` method in `ResourceQuantities`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70149/#review213675 --- Looks good, just some minor stylistic comments that are similar

Re: Review Request 70062: Refactored and augmented `class ResourceQuantities`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70062/#review213672 --- Looks good, just one minor quirk about the += operator, and some

Re: Review Request 70186: Updated protobuf comments related to operation feedback.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70186/#review213674 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 70117: Added unit tests for offer operation feedback metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70117/#review213673 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 70198: Added validation method for input scalar values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70198/#review213671 --- Fix it, then Ship it! Nice to see this consolidated!

Review Request 70200: Changed operation reconciliation to send updates on the event stream.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70200/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, Chun-Hung Hsiao,

Re: Review Request 66746: Replaced protobuf-specific comparators with MessageDifferencer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66746/#review213669 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 70156: Added helper to test for metrics values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70156/ --- (Updated March 13, 2019, 5:45 p.m.) Review request for mesos, Gastón Kleiman,

Re: Review Request 70206: Displayed error message on resource validation failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70206/#review213670 --- Patch looks great! Reviews applied: [70206] Passed command:

Re: Review Request 70117: Added unit tests for offer operation feedback metrics.

> On March 13, 2019, 12:29 a.m., Joseph Wu wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 3832-3845 (original), 3833-3846 (patched) > > > > > > In cases like this, it would be more

Re: Review Request 70117: Added unit tests for offer operation feedback metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70117/ --- (Updated March 13, 2019, 4:01 p.m.) Review request for mesos, Gastón Kleiman,

Review Request 70206: Displayed error message on resource validation failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70206/ --- Review request for mesos, Gastón Kleiman, Greg Mann, and Joseph Wu.

Re: Review Request 70117: Added unit tests for offer operation feedback metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70117/ --- (Updated March 13, 2019, 3:51 p.m.) Review request for mesos, Gastón Kleiman,

[GitHub] [mesos] asekretenko commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo.

asekretenko commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo. URL: https://github.com/apache/mesos/pull/326#discussion_r265197006 ## File path: src/tests/containerizer/composing_containerizer_tests.cpp

[GitHub] [mesos] asekretenko commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo.

asekretenko commented on a change in pull request #326: MESOS-6874: Validate the match between Type and *Infos in the ContainerInfo. URL: https://github.com/apache/mesos/pull/326#discussion_r265196258 ## File path: src/slave/containerizer/composing.cpp ## @@ -425,6

Re: Review Request 70201: Added a method to check `ResourceLimits::contains(ResourceQuantities)`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70201/#review213665 --- Patch looks great! Reviews applied: [70061, 70062, 70069, 70063,

Re: Review Request 70161: Added validation for `QuotaConfig`.

> On March 8, 2019, 9:45 a.m., Benjamin Mahler wrote: > > src/master/quota.cpp > > Lines 328-331 (patched) > > > > > > Maybe also check isnormal? Checked as part of the input scalar validation. - Meng

Review Request 70203: Updated a test for `UPDATE_QUOTA` call validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70203/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-9596

Review Request 70202: Added call handler for `UPDATE_QUOTA`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70202/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-9596

Re: Review Request 70161: Added validation for `QuotaConfig`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70161/ --- (Updated March 12, 2019, 11:41 p.m.) Review request for mesos and Benjamin