Re: Review Request 70472: Ensured that task groups do not specify overlapping ranges or sets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70472/#review214775 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 70506: Added metrics to the operation feedback example framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70506/ --- (Updated April 19, 2019, 4:06 p.m.) Review request for mesos, Benno Evers, Greg

Re: Review Request 70506: Added metrics to the operation feedback example framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70506/#review214774 --- Fix it, then Ship it! src/examples/operation_feedback_framewor

Re: Review Request 70508: Fixed the flaky ExamplesTest.DynamicReservationFramework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70508/#review214773 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 70498: Simplified Sorter::add(client) implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70498/#review214772 --- Patch looks great! Reviews applied: [70498] Passed command: expo

Review Request 70508: Fixed the flaky ExamplesTest.DynamicReservationFramework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70508/ --- Review request for mesos, Chun-Hung Hsiao and Meng Zhu. Bugs: MESOS-5804 ht

Re: Review Request 70498: Simplified Sorter::add(client) implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70498/ --- (Updated April 19, 2019, 7:05 p.m.) Review request for mesos and Meng Zhu. Ch

Re: Review Request 70498: Simplified Sorter::add(client) implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70498/#review214770 --- src/master/allocator/sorter/drf/sorter.cpp Line 169 (original), 1

Re: Review Request 70472: Ensured that task groups do not specify overlapping ranges or sets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70472/#review214769 --- Much simpler! Left a few suggestions below src/master/validation

Re: Review Request 70507: Enabled construction of 'ResourceQuantities' from arbitrary resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70507/#review214768 --- Fix it, then Ship it! Thanks Greg! Could we do a s/arbitrary//

Re: Review Request 70379: Added validation that the principal stays the same on resubscription.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70379/#review214760 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 70472: Ensured that task groups do not specify overlapping ranges or sets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70472/#review214759 --- Patch looks great! Reviews applied: [70507, 70472] Passed comman

Re: Review Request 70507: Enabled construction of 'ResourceQuantities' from arbitrary resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70507/ --- (Updated April 19, 2019, 8:29 a.m.) Review request for mesos, Benno Evers, Benj

Re: Review Request 70507: Enabled construction of 'ResourceQuantities' from arbitrary resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70507/ --- (Updated April 19, 2019, 8:29 a.m.) Review request for mesos, Benno Evers, Benj

Re: Review Request 70472: Ensured that task groups do not specify overlapping ranges or sets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70472/ --- (Updated April 19, 2019, 7:57 a.m.) Review request for mesos, Benno Evers, Benj

Re: Review Request 70472: Ensured that task groups do not specify overlapping ranges or sets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70472/ --- (Updated April 19, 2019, 7:56 a.m.) Review request for mesos, Benno Evers, Benj

Review Request 70507: Enabled construction of 'ResourceQuantities' from arbitrary resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70507/ --- Review request for mesos, Benno Evers, Benjamin Mahler, and Meng Zhu. Bugs: MES

Re: Review Request 70472: Ensured that task groups do not specify overlapping ranges or sets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70472/ --- (Updated April 19, 2019, 7:52 a.m.) Review request for mesos, Benno Evers, Benj

Re: Review Request 70472: Ensured that task groups do not specify overlapping ranges or sets.

> On April 15, 2019, 10:06 p.m., Benjamin Mahler wrote: > > src/master/validation.cpp > > Lines 902-942 (patched) > > > > > > A simpler check might be: > > > > -Add them all together > > -Subtract them a

Re: Review Request 70472: Ensured that task groups do not specify overlapping ranges or sets.

> On April 15, 2019, 10:06 p.m., Benjamin Mahler wrote: > > src/master/validation.cpp > > Lines 1625-1629 (original), 1669-1676 (patched) > > > > > > Hm.. have we validated prior to here that the resources are valid