Re: Review Request 70498: Simplified Sorter::add(client) implementations.

2019-04-22 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70498/#review214802 --- Fix it, then Ship it! Much cleaner, thanks!

Re: Review Request 70519: Transitioned tasks when an unreachable agent is marked as gone.

2019-04-22 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70519/#review214805 --- Patch looks great! Reviews applied: [70518, 70519] Passed

Review Request 70521: Renamed variables in `Master::_accept` to improve readability.

2019-04-22 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70521/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Meng Zhu.

Re: Review Request 70132: Do not implicitly decline speculatively converted resources.

2019-04-22 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70132/ --- (Updated April 23, 2019, 1:15 a.m.) Review request for mesos, Benjamin

Re: Review Request 70509: Added tests for overlapping ranges and sets in task/executor resources.

2019-04-22 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70509/#review214803 --- FAIL: Failed to apply the dependent review: 70507. Failed

Re: Review Request 70519: Transitioned tasks when an unreachable agent is marked as gone.

2019-04-22 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70519/ --- (Updated April 22, 2019, 11:57 p.m.) Review request for mesos, Benno Evers,

Review Request 70519: Sent task status updates when unreachable agent is marked as gone.

2019-04-22 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70519/ --- Review request for mesos, Benno Evers, Gastón Kleiman, Joseph Wu, and Vinod

Review Request 70518: Fixed a memory leak in the master's 'removeTask()' helper.

2019-04-22 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70518/ --- Review request for mesos, Benno Evers, Gastón Kleiman, Joseph Wu, and Vinod

Re: Review Request 70508: Fixed the flaky ExamplesTest.DynamicReservationFramework.

2019-04-22 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70508/#review214800 --- Ship it! Ship It! - Meng Zhu On April 22, 2019, 9:47 a.m.,

Re: Review Request 70517: Added unit test for a master validation helper function.

2019-04-22 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70517/#review214801 --- Landing this patch and preceding ones in the chain; will merge

Re: Review Request 70508: Fixed the flaky ExamplesTest.DynamicReservationFramework.

2019-04-22 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70508/#review214799 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 70509: Added tests for overlapping ranges and sets in task/executor resources.

2019-04-22 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70509/#review214798 --- Patch looks great! Reviews applied: [70507, 70472, 70517, 70509]

Re: Review Request 70517: Added unit test for a master validation helper function.

2019-04-22 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70517/#review214797 --- Ship it! Ship It! - Benjamin Mahler On April 22, 2019, 6:13

Re: Review Request 70508: Fixed the flaky ExamplesTest.DynamicReservationFramework.

2019-04-22 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70508/#review214795 --- Patch looks great! Reviews applied: [70132, 70508] Passed

Re: Review Request 70509: Added tests for overlapping ranges and sets in task/executor resources.

2019-04-22 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70509/ --- (Updated April 22, 2019, 6:14 p.m.) Review request for mesos, Benno Evers,

Review Request 70517: Added unit test for a master validation helper function.

2019-04-22 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70517/ --- Review request for mesos, Benno Evers, Benjamin Mahler, and Gastón Kleiman.

Re: Review Request 70508: Fixed the flaky ExamplesTest.DynamicReservationFramework.

2019-04-22 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70508/ --- (Updated April 22, 2019, 4:47 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 70472: Ensured that task groups do not specify overlapping ranges or sets.

2019-04-22 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70472/#review214793 --- Ship it! Ship It! - Benjamin Mahler On April 22, 2019, 3:32

Re: Review Request 70509: Added tests for overlapping ranges and sets in task/executor resources.

2019-04-22 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70509/#review214790 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 70515: Added a test to verify non-root nested container can access its sandbox.

2019-04-22 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70515/#review214788 --- Patch looks great! Reviews applied: [70514, 70515] Passed

Review Request 70515: Added a test to verify non-root nested container can access its sandbox.

2019-04-22 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70515/ --- Review request for mesos, Andrei Budnik, Gilbert Song, and James Peach. Bugs:

Review Request 70514: Made nested contaienr can access its sandbox via `MESOS_SANDBOX`.

2019-04-22 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70514/ --- Review request for mesos, Andrei Budnik, Gilbert Song, and James Peach. Bugs: