Review Request 70561: Removed the duplicate pid check in Docker containerizer.

2019-04-26 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70561/ --- Review request for mesos, Andrei Budnik and Gilbert Song. Bugs: MESOS-9695

Review Request 70559: Added debug logging when framework is missing during agent removal.

2019-04-26 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70559/ --- Review request for mesos, Benno Evers, Gastón Kleiman, and Joseph Wu. Bugs:

Review Request 70558: Added sending UpdateFrameworkMessage and FRAMEWORK_UPDATED - WIP.

2019-04-26 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70558/ --- Review request for mesos. Repository: mesos Description --- Added

Re: Review Request 70546: WIP: Relaxed protobuf union validation strictness.

2019-04-26 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70546/#review214920 --- Ship it! Ship It! - Benno Evers On April 25, 2019, 8:43

Re: Review Request 70515: Added a test to verify non-root nested container can access its sandbox.

2019-04-26 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70515/#review214919 --- Patch looks great! Reviews applied: [70514, 70515] Passed

Re: Review Request 70514: Made nested contaienr can access its sandbox via `MESOS_SANDBOX`.

2019-04-26 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70514/ --- (Updated April 26, 2019, 3:10 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 70514: Made nested contaienr can access its sandbox via `MESOS_SANDBOX`.

2019-04-26 Thread Qian Zhang
> On April 24, 2019, 7:26 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > > Lines 508 (patched) > > > > > > Seems like this mount point will be on the host fs forever

Re: Review Request 70514: Made nested contaienr can access its sandbox via `MESOS_SANDBOX`.

2019-04-26 Thread Qian Zhang
> On April 24, 2019, 7:26 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/containerizer.cpp > > Lines 1844 (patched) > > > > > > s/has no/does not have/g > > > > could we also mention that