Re: Review Request 70585: Test for a race between resubscriptions with different principals - WIP.

2019-05-03 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70585/#review215043 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 70534: Added tests for UPDATE_FRAMEWORK.

2019-05-03 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70534/#review215042 --- Patch looks great! Reviews applied: [70583, 70531, 70530, 70532,

Re: Review Request 70587: Fixed unguarded calls to `Option::get()` in the master.

2019-05-03 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70587/#review215039 --- Ship it! Ship It! - Gastón Kleiman On May 2, 2019, 3 p.m.,

Re: Review Request 70570: Logged headroom related info in the allocator.

2019-05-03 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70570/#review215038 --- Patch looks great! Reviews applied: [70570] Passed command:

Re: Review Request 70594: Fixed an issue where /__processes__ never returns a response.

2019-05-03 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70594/#review215037 --- Ship it! How about quoting `/__processes__` with backticks? -

Re: Review Request 70595: Adds a regression test for MESOS-9766.

2019-05-03 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70595/#review215035 --- 3rdparty/libprocess/src/tests/process_tests.cpp Lines 2086

Re: Review Request 70580: Added tests for overlapping ranges and sets in task/executor resources.

2019-05-03 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70580/#review215033 --- Patch looks great! Reviews applied: [70579, 70580] Passed

Review Request 70596: Launched tasks with more memory in SLRP unit tests.

2019-05-03 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70596/ --- Review request for mesos, Benjamin Bannier and Jan Schlicht. Bugs: MESOS-9765

Review Request 70594: Fixed an issue where /__processes__ never returns a response.

2019-05-03 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70594/ --- Review request for mesos, Alexander Rukletsov and Chun-Hung Hsiao. Bugs:

Review Request 70595: Adds a regression test for MESOS-9766.

2019-05-03 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70595/ --- Review request for mesos, Alexander Rukletsov and Chun-Hung Hsiao. Bugs:

Review Request 70573: Updated bintray upload scripts to remove hard-coded accounts.

2019-05-03 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70573/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-9697

Re: Review Request 70497: Optimize the random sorter with random sampling.

2019-05-03 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70497/#review215030 --- Patch looks great! Reviews applied: [70419, 70576, 70497]

Re: Review Request 70593: Fixed flaky test FrameworkPrincipalChangeFails.

2019-05-03 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70593/#review215027 --- The review message doesn't conform with our commit message style.

Re: Review Request 70593: Fixed flaky test FrameworkPrincipalChangeFails.

2019-05-03 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70593/#review215022 --- Ship it! Ship It! - Gastón Kleiman On May 3, 2019, 9:38

Review Request 70593: Fixed flaky test FrameworkPrincipalChangeFails.

2019-05-03 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70593/ --- Review request for mesos and Gastón Kleiman. Bugs: MESOS-2842

Review Request 70591: Introduced struct RoleInfo to track reservations and framework IDs in one map.

2019-05-03 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70591/ --- Review request for mesos, Benjamin Mahler and Meng Zhu. Bugs: MESOS-9701

Review Request 70589: Logged when `/__processes__` returns.

2019-05-03 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70589/ --- Review request for mesos, Benjamin Mahler and Till Toenshoff. Repository: