Re: Review Request 70581: Add flag to decouple docker runtime.

2019-05-14 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70581/#review215268 --- Patch looks great! Reviews applied: [70581] Passed command:

Re: Review Request 70581: Add flag to decouple docker runtime.

2019-05-14 Thread Jacob Janco
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70581/ --- (Updated May 14, 2019, 6:51 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 70581: Add flag ignoring docker manifest config metadata.

2019-05-14 Thread Jacob Janco
> On May 14, 2019, 7:20 a.m., James Peach wrote: > > You dropeed the change to > > `src/slave/containerizer/mesos/provisioner/store.cpp`, but AFAICT, you > > still need it. > > > > Please update the relevant `docker/runtime` documentation in ` > > docs/isolators/docker-runtime.md` and

Re: Review Request 70641: Changed Agent GET_STATE for completed executor's tasks (Part 2).

2019-05-14 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70641/#review215249 --- Patch looks great! Reviews applied: [70577, 70641] Passed

Re: Review Request 70618: Encapsulate a framework sorter inside a RoleInfo.

2019-05-14 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70618/#review215245 --- src/master/allocator/mesos/hierarchical.hpp Lines 113-116

Review Request 70641: Changed Agent GET_STATE for completed executor's tasks (Part 2).

2019-05-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70641/ --- Review request for mesos, Gilbert Song, Greg Mann, and Vinod Kone. Bugs:

Re: Review Request 70621: Used full paths as volume IDs for the test CSI plugin.

2019-05-14 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70621/#review215248 --- src/examples/test_csi_plugin.cpp Lines 215 (patched)

Re: Review Request 70295: Enabled launcher sealing for RPM packages.

2019-05-14 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70295/#review215247 --- Ship it! Since Benjamin doesn't have time to finish this

Re: Review Request 70639: Updated URL in CentOS 6 Dockerfile.

2019-05-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70639/#review215246 --- Ship it! Ship It! - Joseph Wu On May 14, 2019, 3:04 a.m.,

Re: Review Request 70620: Made SLRP allow changes in volume context.

2019-05-14 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70620/#review215220 --- Fix it, then Ship it!

Review Request 70639: Updated URL in CentOS 6 Dockerfile.

2019-05-14 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70639/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 70637: Updated CHECK messages in the heirarchical allocator.

2019-05-14 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70637/#review215241 --- Patch looks great! Reviews applied: [70637] Passed command:

Re: Review Request 70581: Add flag ignoring docker manifest config metadata.

2019-05-14 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70581/#review215239 --- You dropeed the change to

Re: Review Request 70637: Updated CHECK messages in the heirarchical allocator.

2019-05-14 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70637/#review215240 --- Fix it, then Ship it! Thanks for adding this!