Re: Review Request 70857: Added the test `ROOT_DisallowShareAgentIPCNamespace`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70857/#review215893 --- Patch looks great! Reviews applied: [70773, 70774, 70775, 70798,

Re: Review Request 70852: Added the test `NamespacesIsolatorTest.ROOT_ShareAgentIPCNamespace`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70852/ --- (Updated June 14, 2019, 11:01 a.m.) Review request for mesos, Andrei Budnik

Review Request 70857: Added the test `ROOT_DisallowShareAgentIPCNamespace`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70857/ --- Review request for mesos, Andrei Budnik and Gilbert Song. Bugs: MESOS-9788

Review Request 70852: Added the test `NamespacesIsolatorTest.ROOT_ShareAgentIPCNamespace`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70852/ --- Review request for mesos. Repository: mesos Description --- Added the

Re: Review Request 70748: Disallow verification of empty TLS server certificates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70748/#review215878 --- 3rdparty/libprocess/src/openssl.cpp Line 738 (original), 745

Re: Review Request 70854: Made scheduler driver's updateFramework() accept FrameworkInfo with ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70854/#review215887 --- How about we simplify and just require the `FrameworkInfo.id` to

Re: Review Request 70815: Added using updateFramework() to java V0 example framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70815/#review215885 --- Bad review! Reviews applied: [70815, 70814, 70813, 70855, 70854]

Re: Review Request 70813: Added updateFramework() method to java V0 scheduler driver bindings.

> On June 13, 2019, 7:04 p.m., Benjamin Mahler wrote: > > src/java/src/org/apache/mesos/SchedulerDriver.java > > Lines 328-336 (patched) > > > > > > Can we fix the ID issue we discussed and get this comment adjusted

Re: Review Request 70813: Added updateFramework() method to java V0 scheduler driver bindings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70813/ --- (Updated June 13, 2019, 7:24 p.m.) Review request for mesos and Benjamin

Review Request 70855: Added tests for handling of FrameworkID by V0 framework updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70855/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 70854: Made scheduler driver's updateFramework() accept FrameworkInfo with ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70854/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 70813: Added updateFramework() method to java V0 scheduler driver bindings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70813/#review215882 --- src/java/src/org/apache/mesos/SchedulerDriver.java Lines 328-336

Re: Review Request 70815: Added using updateFramework() to java V0 example framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70815/#review215881 --- Hm.. most of this change is not related to the updateFramework

Re: Review Request 70814: Replaced a set of single '*' role in SCRIPT_TEST ACL with ANY.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70814/#review215880 --- Ship it! Actually `*` is not a wildcard, so we should adjust

Re: Review Request 70851: Added seconds precision to the DurationInfo protobuf.

> On June 13, 2019, 5:50 a.m., Greg Mann wrote: > > One concern I have with this approach is that, in my opinion, it misses an > > opportunity to decouple our internal representation of durations from the > > representation we expose in the APIs. It seems unnecessary to make a > > breaking

Re: Review Request 70851: Added seconds precision to the DurationInfo protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70851/#review215873 --- One concern I have with this approach is that, in my opinion, it

Re: Review Request 70834: Added minimal agent handler for 'DrainSlaveMessage'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70834/#review215872 --- Are you planning to add the recovery logic later? (That would

Re: Review Request 70822: Added common protobufs for agent draining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70822/#review215871 --- include/mesos/mesos.proto Lines 3721-3723 (patched)

Review Request 70851: Added seconds precision to the DurationInfo protobuf.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70851/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, Greg Mann, and

Re: Review Request 70849: Added the test `NamespacesIsolatorTest.ROOT_PrivateIPCNamespace`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70849/#review215870 --- Patch looks great! Reviews applied: [70773, 70774, 70775, 70798,

Review Request 70849: Added the test `NamespacesIsolatorTest.ROOT_PrivateIPCNamespace`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70849/ --- Review request for mesos, Andrei Budnik and Gilbert Song. Bugs: MESOS-9788

Re: Review Request 70845: Added the test `NamespacesIsolatorTest.ROOT_ShareIPCNamespace`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70845/ --- (Updated June 13, 2019, 2:57 p.m.) Review request for mesos, Andrei Budnik and