[GitHub] [mesos] ArmandGrillet commented on issue #345: Allow `mesos task exec/attach` for any task_id

ArmandGrillet commented on issue #345: Allow `mesos task exec/attach` for any task_id URL: https://github.com/apache/mesos/pull/345#issuecomment-548871609 `mesos-cli-tests` does not pass following the change on my machine: ``` py3-lint: commands succeeded congratulations :)

Re: Review Request 71700: Updated offer operation resource validation for reservation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71700/#review218485 --- Bad review! Reviews applied: [71700, 71696, 71695, 71690, 71688,

Re: Review Request 71688: Reject operator API calls that include reservation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71688/ --- (Updated Nov. 1, 2019, 4:01 p.m.) Review request for mesos and Benjamin

Re: Review Request 71687: Rejected scheduler calls that include reservation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71687/ --- (Updated Nov. 1, 2019, 3:59 p.m.) Review request for mesos and Benjamin

Re: Review Request 71699: Consolidated 'Master::authorizeReserveResources' overloads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71699/ --- (Updated Nov. 1, 2019, 3:59 p.m.) Review request for mesos and Benjamin

Re: Review Request 71641: Garbage-collected lost tasks which are reported as running again.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71641/#review218484 --- Patch looks great! Reviews applied: [71641] Passed command:

Review Request 71709: Removed an empty line as flagged by cpplint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71709/ --- Review request for mesos, Benno Evers and Benjamin Mahler. Repository: mesos

Re: Review Request 71709: Removed an empty line as flagged by cpplint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71709/#review218483 --- Ship it! Ship It! - Benno Evers On Nov. 1, 2019, 3:12 p.m.,

Re: Review Request 71641: Garbage-collected lost tasks which are reported as running again.

> On Oct. 30, 2019, 11:38 p.m., Greg Mann wrote: > > src/tests/master_tests.cpp > > Lines 11128 (patched) > > > > > > Looks like the compiler is complaining about a type mismatch here. Yikes, I am in shock my

Re: Review Request 71641: Garbage-collected lost tasks which are reported as running again.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71641/ --- (Updated Nov. 1, 2019, 1:08 p.m.) Review request for mesos, Benno Evers,

Re: Review Request 71690: Added function to compute a common reservation ancestor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71690/#review218481 --- I think this patch does what we need. We want a function which