Re: Review Request 71858: Set resource limits when launching executor container.

> On Jan. 8, 2020, 5:43 a.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 3140-3201 (patched) > > > > > > I think maybe this logic could be easier to read if we do something > > like: > > > > ``` >

Re: Review Request 72096: Store per-framework ObjectApprovers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72096/#review219687 --- Ship it! src/master/framework.cpp Lines 735 (patched)

Re: Review Request 72095: Introduced dedicated `Framework` methods for transitions between states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72095/#review219686 --- Fix it, then Ship it! src/master/master.cpp Line 12498

Re: Review Request 72099: Removed code for tracking pending tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72099/#review219685 --- Patch looks great! Reviews applied: [72130, 72094, 72095, 72089,

Re: Review Request 72169: Made `overload()` work with callables passed by reference.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72169/#review219684 --- Ship it! Ship It! - Benjamin Mahler On Feb. 27, 2020, 6:41

Re: Review Request 72099: Removed code for tracking pending tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72099/ --- (Updated Feb. 27, 2020, 6:43 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 72098: Converted ACCEPT to synchronous authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72098/ --- (Updated Feb. 27, 2020, 6:41 p.m.) Review request for mesos, Benjamin Mahler

Review Request 72169: Made `overload()` work with callables passed by reference.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72169/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 72096: Store per-framework ObjectApprovers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72096/ --- (Updated Feb. 27, 2020, 6:38 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 72093: Added to `ObjectApprovers` a method to approve arbitrary action.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72093/ --- (Updated Feb. 27, 2020, 6:36 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 72089: Introduced `getApprover(...)` authorizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72089/ --- (Updated Feb. 27, 2020, 6:28 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 72095: Introduced dedicated `Framework` methods for transitions between states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72095/ --- (Updated Feb. 27, 2020, 6:25 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 71858: Set resource limits when launching executor container.

> On Jan. 7, 2020, 9:43 p.m., Greg Mann wrote: > > src/slave/slave.cpp > > Lines 3140-3201 (patched) > > > > > > I think maybe this logic could be easier to read if we do something > > like: > > > > ``` >

Re: Review Request 72161: Added patch for RapidJSON.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72161/#review219677 --- Is the plan to upstream this patch? We usually try to enable

Re: Review Request 72161: Added patch for RapidJSON.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72161/#review219676 --- 3rdparty/CMakeLists.txt Lines 482-484 (original), 482-487

Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72162/#review219673 --- 3rdparty/stout/include/stout/jsonify.hpp Line 91 (original),

Re: Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.

> On Feb. 25, 2020, 5:23 p.m., Andrei Budnik wrote: > > 3rdparty/stout/include/stout/protobuf.hpp > > Lines 551 (patched) > > > > > > It looks like `JSON::parse()` alone can't parse infinite values from a > > json

Re: Review Request 71950: Updated containerizer's `update()` method to handle resource limits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71950/#review219674 --- src/tests/master_tests.cpp Line 202 (original), 202 (patched)