Re: Review Request 72216: Added master validation for task resource limits and shared cgroups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72216/#review219855 --- src/master/validation.cpp Lines 1567 (patched)

Re: Review Request 72190: Added a test `LaunchNestedShareCgroups`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72190/#review219854 --- Patch looks great! Reviews applied: [72121, 71965, 71966, 72122,

Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.

> On Март 8, 2020, 2:29 п.п., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > > Lines 743-748 (original), 758-762 (patched) > > > > > > I think this is for the case: Agent is

Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.

> On Янв. 13, 2020, 3:21 д.п., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > > Lines 779-785 (original), 797-803 (patched) > > > > > > This logic is correct for root container

Re: Review Request 72217: Added tests for resource limit and shared cgroup validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72217/#review219850 --- Bad patch! Reviews applied: [72161, 72162, 71858, 71884, 71885,

Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72041/#review219848 --- Bad patch! Reviews applied: [72161, 72162, 71858, 71884, 71885,

Review Request 72217: Added tests for resource limit and shared cgroup validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72217/ --- Review request for mesos, Andrei Budnik and Qian Zhang. Bugs: MESOS-10045

Review Request 72216: Added master validation for task resource limits and shared cgroups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72216/ --- Review request for mesos, Andrei Budnik and Qian Zhang. Bugs: MESOS-10045

Review Request 72215: Added resource limits to one overload of 'createTask()' helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72215/ --- Review request for mesos, Andrei Budnik and Qian Zhang. Bugs: MESOS-10045

Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.

> On March 8, 2020, 10:29 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > > Line 411 (original), 412 (patched) > > > > > > s/with/from/ > > Greg Mann wrote: > I think

Re: Review Request 71952: Set resource limits when updating executor container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71952/ --- (Updated March 9, 2020, 10:08 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 71951: Added resource limits into the `Task` protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71951/ --- (Updated March 9, 2020, 10:05 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 71858: Set resource limits when launching executor container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71858/ --- (Updated March 9, 2020, 10:04 p.m.) Review request for mesos, Andrei Budnik

Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71965/#review219843 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp Line

Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.

> On March 8, 2020, 2:29 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > > Line 411 (original), 412 (patched) > > > > > > s/with/from/ I think "with" is actually the

Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71965/#review219830 --- In the description: should be "explicitly disabled