Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.

2020-03-17 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72041/#review219980 --- Bad patch! Reviews applied: [72161, 72162, 71858, 71884, 71885, 7

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

2020-03-17 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71983/#review219979 --- src/tests/containerizer/cgroups_isolator_tests.cpp Lines 900-902

Re: Review Request 72022: Set resource limits and OOM score adjustment in Docker executor.

2020-03-17 Thread Greg Mann
> On March 16, 2020, 11:54 a.m., Greg Mann wrote: > > src/docker/executor.cpp > > Lines 201-212 (original), 201-212 (patched) > > > > > > We also have the less common case of a custom executor in a Docker > > contai

Re: Review Request 72022: Set resource limits and OOM score adjustment in Docker executor.

2020-03-17 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72022/#review219978 --- Ship it! Ship It! - Greg Mann On March 16, 2020, 9:16 a.m.,

Re: Review Request 72211: Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.

2020-03-17 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72211/#review219976 --- Ship it! Ship It! - Greg Mann On March 17, 2020, 7:01 a.m.,

Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs`.

2020-03-17 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71953/#review219975 --- Ship it! Ship It! - Greg Mann On March 17, 2020, 7:03 a.m.,

Re: Review Request 72210: Added a test `ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.

2020-03-17 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72210/#review219974 --- Ship it! Ship It! - Greg Mann On March 17, 2020, 7:08 a.m.,

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

2020-03-17 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71983/ --- (Updated March 18, 2020, 10:01 a.m.) Review request for mesos, Andrei Budnik an

Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.

2020-03-17 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72041/#review219970 --- Bad patch! Reviews applied: [72161, 72162, 71858, 71884, 71885, 7

Re: Review Request 72222: Added tests for agent validation of shared cgroups.

2020-03-17 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7/#review219969 --- Bad patch! Reviews applied: [72161, 72162, 71858, 71884, 71885, 7

Re: Review Request 72210: Added a test `ROOT_CGROUPS_CFS_CommandTaskInfiniteLimits`.

2020-03-17 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72210/ --- (Updated March 17, 2020, 3:08 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs`.

2020-03-17 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71953/ --- (Updated March 17, 2020, 3:03 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.

2020-03-17 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71983/ --- (Updated March 17, 2020, 3:02 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72211: Added a test `ROOT_DOCKER_CGROUPS_CFS_CommandTaskInfiniteLimits`.

2020-03-17 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72211/ --- (Updated March 17, 2020, 3:01 p.m.) Review request for mesos, Andrei Budnik and