Re: Review Request 72448: Fixed operator api event inconsistencies issue.

2020-07-14 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72448/#review221208 --- Patch looks great! Reviews applied: [72448] Passed command:

Re: Review Request 72448: Fixed operator api event inconsistencies issue.

2020-07-14 Thread Dong Zhu
> On April 29, 2020, 2:58 p.m., Andrei Sekretenko wrote: > > src/master/master.cpp > > Lines 12264 (patched) > > > > > > As implemented now, `false` returned by `ObjectApprovers::approved()` > > is not

Re: Review Request 72448: Fixed operator api event inconsistencies issue.

2020-07-14 Thread Dong Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72448/ --- (Updated July 14, 2020, 9:43 a.m.) Review request for mesos, Andrei Sekretenko

Re: Review Request 72672: Introduced a new agent flag `--csi_plugin_config_dir`.

2020-07-14 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72672/#review221206 --- Patch looks great! Reviews applied: [72660, 72661, 72672]

Re: Review Request 72660: Added CSI volume type into the `Volume` protobuf message.

2020-07-14 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72660/ --- (Updated July 14, 2020, 2:44 p.m.) Review request for mesos, Andrei Budnik and