Re: Review Request 72753: Implemented the `recover` method of `volume/csi` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72753/#review221537 --- src/slave/containerizer/mesos/isolators/volume/csi/isolator.hpp

Re: Review Request 72733: Implemented the `prepare` method of `volume/csi` isolator.

> On Aug. 6, 2020, 1:27 a.m., Greg Mann wrote: > > src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp > > Lines 115-117 (patched) > > > > > > This seems pretty simple, could we do it now? > > Qian

Re: Review Request 72690: Implemented the framework and `create` method of `volume/csi` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72690/#review221535 --- Ship it! Ship It! - Greg Mann On Aug. 8, 2020, 3:58 p.m.,

Re: Review Request 72732: Added support for secrets to the CSI volume managers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72732/#review221534 --- Ship it! Ship It! - Qian Zhang On Aug. 11, 2020, 12:20

Re: Review Request 72716: Added implementation of the CSI server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72716/ --- (Updated Aug. 11, 2020, 4:22 a.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72732: Added support for secrets to the CSI volume managers.

> On Aug. 10, 2020, 9:07 a.m., Qian Zhang wrote: > > src/csi/v0_volume_manager_process.hpp > > Lines 186 (patched) > > > > > > I do not see how this secret resolver is used in v0 volume manager. :facepalm: > On

Re: Review Request 72732: Added support for secrets to the CSI volume managers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72732/ --- (Updated Aug. 11, 2020, 4:20 a.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72754: Enabled the `volume/csi` isolator in `MesosContainerizer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72754/#review221532 --- Bad patch! Reviews applied: [72660, 72661, 72672, 72681, 72715,

Re: Review Request 72728: Added a unit test for the CSI server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72728/ --- (Updated Aug. 11, 2020, 3:08 a.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72727: Updated the test CSI plugin for CSI server testing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72727/ --- (Updated Aug. 11, 2020, 3:07 a.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72716: Added implementation of the CSI server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72716/#review221531 --- Ship it! Ship It! - Qian Zhang On Aug. 11, 2020, 10:30

Re: Review Request 72716: Added implementation of the CSI server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72716/ --- (Updated Aug. 11, 2020, 2:30 a.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72716: Added implementation of the CSI server.

> On Aug. 7, 2020, 12:01 p.m., Qian Zhang wrote: > > src/slave/csi_server.cpp > > Lines 336 (patched) > > > > > > Do we need to check if `volume/csi` isolator is enabled? Like: > > ``` > > if

Re: Review Request 72732: Added support for secrets to the CSI volume managers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72732/#review221520 --- src/csi/v0_volume_manager_process.hpp Lines 186 (patched)

Re: Review Request 72727: Updated the test CSI plugin for CSI server testing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72727/#review221524 --- src/examples/test_csi_plugin.cpp Lines 232-235 (original),

Re: Review Request 72728: Added a unit test for the CSI server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72728/#review221523 --- src/Makefile.am Lines 2831 (patched)