Re: Review Request 72728: Added a unit test for the CSI server.

2020-08-12 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72728/#review221562 --- Patch looks great! Reviews applied: [72732, 72716, 72690, 72733,

Re: Review Request 72760: Passed the CSI server into the Mesos containerizer.

2020-08-12 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72760/#review221561 --- Ship it! Ship It! - Qian Zhang On Aug. 13, 2020, 3:21 a.m.,

Re: Review Request 72761: Added the CSI server to the Mesos agent.

2020-08-12 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72761/#review221560 --- src/slave/main.cpp Lines 577 (patched)

Re: Review Request 72728: Added a unit test for the CSI server.

2020-08-12 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72728/ --- (Updated Aug. 12, 2020, 7:21 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72760: Passed the CSI server into the Mesos containerizer.

2020-08-12 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72760/ --- (Updated Aug. 12, 2020, 7:21 p.m.) Review request for mesos and Qian Zhang.

Re: Review Request 72728: Added a unit test for the CSI server.

2020-08-12 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72728/ --- (Updated Aug. 12, 2020, 7:20 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72761: Added the CSI server to the Mesos agent.

2020-08-12 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72761/ --- (Updated Aug. 12, 2020, 7:19 p.m.) Review request for mesos and Qian Zhang.

Review Request 72761: Added the CSI server to the Mesos agent.

2020-08-12 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72761/ --- Review request for mesos and Qian Zhang. Bugs: MESOS-10163

Review Request 72760: Passed the CSI server into the Mesos containerizer.

2020-08-12 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72760/ --- Review request for mesos and Qian Zhang. Bugs: MESOS-10163

Re: Review Request 72728: Added a unit test for the CSI server.

2020-08-12 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72728/ --- (Updated Aug. 12, 2020, 7:13 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72726: Fixed a bug in CSI volume manager initialization.

2020-08-12 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72726/ --- (Updated Aug. 12, 2020, 7:03 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72740: Introduced an interface for plugging offer filtering into the allocator.

2020-08-12 Thread Andrei Sekretenko
> On Aug. 11, 2020, 8:55 p.m., Benjamin Mahler wrote: > > include/mesos/allocator/allocator.hpp > > Lines 72-96 (patched) > > > > > > Hm.. `AgentResourcesFilter` as a name looks a bit unintuitive since > > resources

Re: Review Request 72709: Fixed the tests warning messages.

2020-08-12 Thread Dong Zhu
> On July 28, 2020, 1:12 a.m., Benjamin Mahler wrote: > > Hm.. it seems this was done to support running the tests from an > > installation? > > > > https://github.com/apache/mesos/commit/6cca8c8071e4b863d951a1631141f861c47826d1 > > Dong Zhu wrote: > Yes. But this issue exists even from

Re: Review Request 72759: Improved CSI service manager to set node ID for managed CSI plugins.

2020-08-12 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72759/#review221557 --- Patch looks great! Reviews applied: [72759] Passed command:

Review Request 72759: Improved CSI service manager to set node ID for managed CSI plugins.

2020-08-12 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72759/ --- Review request for mesos, Andrei Budnik and Greg Mann. Bugs: MESOS-10175