Re: Review Request 72805: Added a test helper for CSI volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72805/#review221713 --- Fix it, then Ship it! src/tests/mesos.hpp Lines 873-874 (patch

Re: Review Request 72728: Added tests for the 'volume/csi' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72728/ --- (Updated Aug. 26, 2020, 5:57 a.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72728: Added tests for the 'volume/csi' isolator.

> On Aug. 25, 2020, 2:41 p.m., Qian Zhang wrote: > > src/tests/csi_server_tests.cpp > > Lines 457 (patched) > > > > > > It seems we only want to verify the behavior of CSI server but not > > launch a task from end t

Review Request 72805: Added a test helper for CSI volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72805/ --- Review request for mesos and Qian Zhang. Repository: mesos Description --

Re: Review Request 72804: Supported chown CSI volumes in the `volume/csi` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72804/#review221710 --- Bad patch! Reviews applied: [72804, 72803] Failed command: cd ..

Review Request 72803: Added a new agent flag `--csi_volume_chown`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72803/ --- Review request for mesos, Andrei Budnik and Greg Mann. Bugs: MESOS-10153 ht

Review Request 72804: Supported chown CSI volumes in the `volume/csi` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72804/ --- Review request for mesos, Andrei Budnik and Greg Mann. Bugs: MESOS-10153 ht

Re: Review Request 72787: Added basic tests for regexp-based constraints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72787/#review221709 --- Bad patch! Reviews applied: [72787, 72786, 72784, 72783, 72782, 7

Re: Review Request 72786: Implemented regex-based offer constraints.

> On Aug. 24, 2020, 9:30 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/offer_constraints_filter.cpp > > Lines 113-119 (patched) > > > > > > How did you figure this out? Just from your own testing? > >

Re: Review Request 72786: Implemented regex-based offer constraints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72786/ --- (Updated Aug. 25, 2020, 6:43 p.m.) Review request for mesos and Benjamin Mahler

Re: Review Request 72784: Added protobuf messages for regex-based offer constraints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72784/ --- (Updated Aug. 25, 2020, 6:38 p.m.) Review request for mesos and Benjamin Mahler

Re: Review Request 72728: Added unit tests for the CSI server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72728/#review221703 --- src/tests/csi_server_tests.cpp Lines 19 (patched)

Re: Review Request 72785: Introduced a weak_ptr-based cache abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72785/#review221706 --- Bad patch! Reviews applied: [72785] Failed command: cd .. && /us

Re: Review Request 72786: Implemented regex-based offer constraints.

> On Aug. 24, 2020, 9:30 p.m., Benjamin Mahler wrote: > > Hm.. is it possible to have a simpler patch that avoids the factory and > > instead passes the flags through the creation path? This is possible; however, I would argue that putting limits on RE2 is rather deep implemenation detail whic

Re: Review Request 72776: Added basic tests for offer constraints on a string attribute equality.

> On Aug. 24, 2020, 9:14 p.m., Benjamin Mahler wrote: > > Do we also want to be checking pseudoattributes? (Different enums and > > handling optionality (e.g. domain)). We surely need. Added https://issues.apache.org/jira/browse/MESOS-10180 to the epic for this (and for other poorly covered fu