Re: Review Request 72448: Fixed operator api event inconsistencies issue.

2020-09-24 Thread Dong Zhu
> On July 18, 2020, 1:10 a.m., Andrei Sekretenko wrote: > > Thanks! Now this patch addresses the main issue. > > Dong Zhu wrote: > I updated the patch, this time I do not handle > `approvers->approved(resource)` in `void > Master::Subscribers::Subscriber::send()` specifically since I do no

Re: Review Request 72709: Fixed the tests warning messages.

2020-09-24 Thread Dong Zhu
> On July 28, 2020, 1:12 a.m., Benjamin Mahler wrote: > > Hm.. it seems this was done to support running the tests from an > > installation? > > > > https://github.com/apache/mesos/commit/6cca8c8071e4b863d951a1631141f861c47826d1 > > Dong Zhu wrote: > Yes. But this issue exists even from an

Re: Review Request 72900: Added offer constraints to `updateFramework()` in the Java bindings.

2020-09-24 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72900/#review221954 --- Fix it, then Ship it! src/examples/java/TestFramework.java Lin

Re: Review Request 72874: Added offer constraints to `MesosSchedulerDriver::updateFramework()`.

2020-09-24 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72874/#review221953 --- Ship it! include/mesos/scheduler.hpp Lines 364-365 (original),

Re: Review Request 72897: Made offer constraints filter and protobuf non-optional inside the code.

2020-09-24 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72897/#review221952 --- Ship it! include/mesos/allocator/allocator.hpp Line 113 (origi

Re: Review Request 72899: Added a test for creating a filter from default `OfferConstraints`.

2020-09-24 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72899/#review221951 --- Ship it! src/tests/master/offer_constraints_filter_tests.cpp L

Re: Review Request 72898: Added `OfferConstraints` validity criteria into protobuf comments.

2020-09-24 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72898/#review221950 --- Ship it! Thanks for adding this, I think we should maybe just s

Re: Review Request 72901: WIP: Added setting offer constraints to the Java example framework.

2020-09-24 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72901/#review221949 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 72898: Added `OfferConstraints` validity criteria into protobuf comments.

2020-09-24 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72898/ --- (Updated Sept. 24, 2020, 5:13 p.m.) Review request for mesos and Benjamin Mahle

Re: Review Request 72897: Made offer constraints filter and protobuf non-optional inside the code.

2020-09-24 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72897/ --- (Updated Sept. 24, 2020, 5:07 p.m.) Review request for mesos and Benjamin Mahle

Re: Review Request 72899: Added a test for creating a filter from default `OfferConstraints`.

2020-09-24 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72899/ --- (Updated Sept. 24, 2020, 5:06 p.m.) Review request for mesos and Benjamin Mahle