Re: Review Request 72709: Fixed the tests warning messages.

2020-10-16 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72709/#review222064 --- Ship it! Ship It! - Benjamin Mahler On Aug. 4, 2020, 4:30

Re: Review Request 72448: Fixed operator api event inconsistencies issue.

2020-10-16 Thread Andrei Sekretenko
> On Sept. 25, 2020, 10:26 p.m., Andrei Sekretenko wrote: > > src/common/http.hpp > > Lines 422-426 (patched) > > > > > > Just `return approved(...)` ? > > Dong Zhu wrote: > I got totally confused here, I have

Re: Review Request 72448: Fixed operator api event inconsistencies issue.

2020-10-16 Thread Dong Zhu
> On Sept. 26, 2020, 4:26 a.m., Andrei Sekretenko wrote: > > src/common/http.hpp > > Lines 422-426 (patched) > > > > > > Just `return approved(...)` ? I got totally confused here, I have no idea what you mean. Can