Re: Review Request 59177: CLI: Added Config class to manage the config file.

/cli_new/lib/cli/util.py 27c4f17e4b75f63f2fb31f0ad27a464227d29448 Diff: https://reviews.apache.org/r/59177/diff/2/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

/58720/diff/11/ Changes: https://reviews.apache.org/r/58720/diff/10-11/ Testing --- PEP8 and Pylint used to make sure that the code style is correct. Manuel test: $ cd src/cli_new $ ./bootstrap $ source activate (mesos-cli) $ mesos-cli-tests Thanks, Armand Grillet

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

://reviews.apache.org/r/58720/diff/7/ Changes: https://reviews.apache.org/r/58720/diff/6-7/ Testing --- PEP8 and Pylint used to make sure that the code style is correct. Manuel test: $ cd src/cli_new $ ./bootstrap $ source activate (mesos-cli) $ mesos-cli-tests Thanks, Armand Grillet

Re: Review Request 59177: CLI: Added Config class to manage the config file.

is correct. Thanks, Armand Grillet

Review Request 59177: CLI: Added Config class to manage the config file.

that the code style is correct. Thanks, Armand Grillet

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

re script with `--with-mesos-build-dir`. Our script mesos-cli-tests is currently small and supporting long command line options is gonna require a lot of code (it does not work out of the box on macOS). The easiest solution would be to have a short command line option to specify your build path (e.g. `mesos-cli-tests -b=path/to/mesos/build/dir`). - Armand

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

://reviews.apache.org/r/58720/diff/5/ Changes: https://reviews.apache.org/r/58720/diff/4-5/ Testing --- PEP8 and Pylint used to make sure that the code style is correct. Manuel test: $ cd src/cli_new $ ./bootstrap $ source activate (mesos-cli) $ mesos-cli-tests Thanks, Armand Grillet

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

Thanks, Armand Grillet

Re: Review Request 58137: CLI: Added 'mesos config show' command to display the config file.

: https://reviews.apache.org/r/58137/diff/7/ Changes: https://reviews.apache.org/r/58137/diff/6-7/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

/ Testing --- PEP8 and Pylint used to make sure that the code style is correct. Manuel test: $ cd src/cli_new $ ./bootstrap $ source activate (mesos-cli) $ mesos-cli-tests Thanks, Armand Grillet

Review Request 58719: CLI: Added utility functions related to HTTP.

--- This will be used by future plugins and tests. Diffs - src/cli_new/lib/cli/http.py PRE-CREATION Diff: https://reviews.apache.org/r/58719/diff/1/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet

Review Request 58720: CLI: Extended the unit test infrastructure.

/main.py dff5d48b0ddae87960a78f9d05e4ae597912f1f6 Diff: https://reviews.apache.org/r/58720/diff/1/ Testing --- PEP8 and Pylint used to make sure that the code style is correct. Manuel test: $ cd src/cli_new $ ./bootstrap $ source activate (mesos-cli) $ mesos-cli-tests Thanks, Armand

Re: Review Request 57951: Moved new CLI settings into a user-defined TOML file.

e73bbfde98f28693463a46b166197ad1fd53c0cb Diff: https://reviews.apache.org/r/57951/diff/6/ Changes: https://reviews.apache.org/r/57951/diff/5-6/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet

Re: Review Request 58137: Added 'mesos config show' command to display the config file.

/58137/diff/3-4/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet

Re: Review Request 57952: Added 'config' plugin to the new CLI.

is correct. Thanks, Armand Grillet

Review Request 58381: Added a Table abstraction to the new CLI.

and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet

Re: Review Request 57951: Moved new CLI settings into a user-defined TOML file.

9cc8d096ac353f4ed2d4318f2d0e439a6edf Diff: https://reviews.apache.org/r/57951/diff/5/ Changes: https://reviews.apache.org/r/57951/diff/4-5/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet

Re: Review Request 58137: Added 'mesos config show' command to display the config file.

: https://reviews.apache.org/r/58137/diff/2-3/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet

Re: Review Request 57952: Added 'config' plugin to the new CLI.

/ Changes: https://reviews.apache.org/r/57952/diff/3-4/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet

Re: Review Request 57951: Moved new CLI settings into a user-defined TOML file.

9cc8d096ac353f4ed2d4318f2d0e439a6edf Diff: https://reviews.apache.org/r/57951/diff/4/ Changes: https://reviews.apache.org/r/57951/diff/3-4/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet

Re: Review Request 58137: Added 'mesos config show' command to display the config file.

PRE-CREATION Diff: https://reviews.apache.org/r/58137/diff/2/ Changes: https://reviews.apache.org/r/58137/diff/1-2/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet

Re: Review Request 57952: Added 'config' plugin to the new CLI.

/57952/diff/2-3/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet

Re: Review Request 57951: Moved new CLI settings into a user-defined TOML file.

used to make sure that the code style is correct. Thanks, Armand Grillet

Review Request 58146: Added infrastructure for unit tests in the new python-based CLI.

9cc8d096ac353f4ed2d4318f2d0e439a6edf src/cli_new/tests/main.py PRE-CREATION Diff: https://reviews.apache.org/r/58146/diff/1/ Testing --- $ cd src/cli_new $ ./bootstrap $ source activate (mesos-cli) $ mesos-cli-tests Thanks, Armand Grillet

Review Request 58137: Added `mesos config show` command to display the config file.

is correct. Thanks, Armand Grillet

Re: Review Request 57951: Moved new CLI settings into a user-defined TOML file.

274f8c63b0c642637f17aa2e3c8c4a8a5a059e37 src/cli_new/pip-requirements.txt 9cc8d096ac353f4ed2d4318f2d0e439a6edf Diff: https://reviews.apache.org/r/57951/diff/1/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet

Re: Review Request 57952: Added 'config' plugin to the new CLI.

src/cli_new/lib/mesos/plugins/config/main.py PRE-CREATION Diff: https://reviews.apache.org/r/57952/diff/1/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet

Review Request 57952: Added 'config' plugin to the new CLI.

/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet

Re: Review Request 57951: Moved new CLI settings into a user-defined TOML file.

9cc8d096ac353f4ed2d4318f2d0e439a6edf Diff: https://reviews.apache.org/r/57951/diff/1/ Testing (updated) --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet

Review Request 57951: Moved new CLI settings into a user-defined TOML file.

://reviews.apache.org/r/57951/diff/1/ Testing --- Thanks, Armand Grillet

Review Request 57896: Configuration of cli_new in config.toml file.

/mesos/plugins/config/main.py PRE-CREATION src/cli_new/pip-requirements.txt 9cc8d096ac353f4ed2d4318f2d0e439a6edf Diff: https://reviews.apache.org/r/57896/diff/1/ Testing --- Tested manually, PEP8 and Pylint used to make sure that the code style is correct. Thanks, Armand Grillet

Review Request 56326: Size of the favicon optimized.

. I took care of converting 'favicon.ico' to '.png' images using imagemagick, optimized their size using ImageOptim, and rebundled them as 'favicon.ico' using imagemagick again. Thanks, Armand Grillet

Re: Review Request 50010: Added example framework for handling inverse offers.

other flags added. Doing a `make check` with this patch on top of `master` did not work, modifying it following the two comments above fixed the problem. - Armand Grillet On Sept. 16, 2016, 9:35 p.m., Jos

Re: Review Request 53559: Transformed env variable parsing into Flags in process.cpp.

) are now in a Flags object. Diffs (updated) - 3rdparty/libprocess/src/process.cpp ab2b5a9d38a3001d6a5daa1807fecb630c4b154d Diff: https://reviews.apache.org/r/53559/diff/ Testing --- make check (macOS) Thanks, Armand Grillet

Re: Review Request 53558: Added net::IP parsing template to the flags parsers.

, Armand Grillet

Re: Review Request 53558: Added net::IP parsing template to the flags parsers.

) Thanks, Armand Grillet

Re: Review Request 53509: Changed mesos-execute --master flag parsing.

:2181/mesos` and then executing a sleep task on Mesos with `--master=zk://localhost:2181/mesos`. Thanks, Armand Grillet

Review Request 53560: LOG(FATAL) transformed into EXIT(EXIT_FAILURE) in process::initialize.

/diff/ Testing --- make check (macOS) Thanks, Armand Grillet

Review Request 53559: Transformed env variable parsing into Flags in process.cpp.

/libprocess/src/process.cpp ab2b5a9d38a3001d6a5daa1807fecb630c4b154d Diff: https://reviews.apache.org/r/53559/diff/ Testing --- make check (macOS) Thanks, Armand Grillet

Review Request 53558: Added net::IP parsing template to the flags parsers.

--- Will be used to have flags of type `net::IP`. Diffs - 3rdparty/stout/include/stout/flags/parse.hpp 67a89c9068207b2197d60f3542962e82327a43a4 Diff: https://reviews.apache.org/r/53558/diff/ Testing --- make check (macOS) Thanks, Armand Grillet

Re: Review Request 53509: Flag --master now required and parsed by MasterDetector.

://localhost:2181/mesos` and then executing a sleep task on Mesos with `--master=zk://localhost:2181/mesos`. Thanks, Armand Grillet

Re: Review Request 53509: Flag —master now required and parsed by MasterDetector.

://localhost:2181/mesos`. Thanks, Armand Grillet

Review Request 53509: Flag —master now required and parsed by MasterDetector.

/diff/ Testing --- Testing done by running a master with `--zk=zk://localhost:2181/mesos` then an agent with `--master=zk://localhost:2181/mesos` and then executing a sleep task on Mesos with `--master=zk://localhost:2181/mesos`. Thanks, Armand Grillet

<    1   2   3   4   5   6