a5536b3d735e01eb1c4dc52d0602d973155f3c93
Diff: https://reviews.apache.org/r/70245/diff/3/
Changes: https://reviews.apache.org/r/70245/diff/2-3/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
/
Changes: https://reviews.apache.org/r/70316/diff/1-2/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
/2/
Changes: https://reviews.apache.org/r/70314/diff/1-2/
Testing
---
make check
The new code path is tested later in this chain.
Thanks,
Chun-Hung Hsiao
src/tests/master_validation_tests.cpp
7f3751aa04c127c769cfd73ecb47c714e916db41
Diff: https://reviews.apache.org/r/70313/diff/2/
Changes: https://reviews.apache.org/r/70313/diff/1-2/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
` disk.
Diffs
-
src/tests/storage_local_resource_provider_tests.cpp
7945384867f26fa15dc734a235ae509d5d6d350f
Diff: https://reviews.apache.org/r/70316/diff/1/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
://reviews.apache.org/r/70315/diff/1/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
the underlying CSI
volume will be deprovisioned.
Diffs
-
src/resource_provider/storage/provider.cpp
fea623c292158deb1b4b4b9ab1ac208031471519
Diff: https://reviews.apache.org/r/70314/diff/1/
Testing
---
make check
The new code path is tested later in this chain.
Thanks,
Chun-Hung Hsiao
ache.org/r/70313/diff/1/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
n March 16, 2019, 12:02 a.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70223/
> -
/tests/csi_utils_tests.cpp PRE-CREATION
src/tests/disk_profile_adaptor_tests.cpp
0ccbc79d7ffb82a68b7ed5aeab930bcd8e6e770e
src/tests/mock_csi_plugin.hpp 6897fbc878f1e2f5b9e9c402b09358c187af79a0
Diff: https://reviews.apache.org/r/70302/diff/1/
Testing
---
make check
Thanks,
Chun-Hung
ache.org/r/70247/diff/3/
Changes: https://reviews.apache.org/r/70247/diff/2-3/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
/storage_local_resource_provider_tests.cpp
7945384867f26fa15dc734a235ae509d5d6d350f
Diff: https://reviews.apache.org/r/70222/diff/4/
Changes: https://reviews.apache.org/r/70222/diff/3-4/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
://reviews.apache.org/r/70214/diff/4/
Changes: https://reviews.apache.org/r/70214/diff/3-4/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
ntics to our own
> > semantics instead of leaking the CSI protocol? I think not using a magic
> > value of `0` would be nice.
> >
> > Seems like we could either return a `Failure` if `GET_CAPACITY` is not
> > supported or some `Option::none()`. This would
://reviews.apache.org/r/70168/diff/9/
Changes: https://reviews.apache.org/r/70168/diff/8-9/
Testing
---
Testing done later in chain.
Thanks,
Chun-Hung Hsiao
Thanks,
Chun-Hung Hsiao
://reviews.apache.org/r/70248/diff/3/
Changes: https://reviews.apache.org/r/70248/diff/2-3/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
volume_manager.cpp
> > Lines 202 (patched)
> > <https://reviews.apache.org/r/70215/diff/2/?file=2132473#file2132473line202>
> >
> > Break line before `.then`.
Fixed in r/70222.
- Chun-Hung
-----
/v0_volume_manager.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/70285/diff/1/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
-
src/resource_provider/storage/provider.cpp
fea623c292158deb1b4b4b9ab1ac208031471519
src/resource_provider/storage/provider_process.hpp
a5536b3d735e01eb1c4dc52d0602d973155f3c93
Diff: https://reviews.apache.org/r/70284/diff/1/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
fea623c292158deb1b4b4b9ab1ac208031471519
src/resource_provider/storage/provider_process.hpp
a5536b3d735e01eb1c4dc52d0602d973155f3c93
Diff: https://reviews.apache.org/r/70217/diff/5/
Changes: https://reviews.apache.org/r/70217/diff/4-5/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
a5536b3d735e01eb1c4dc52d0602d973155f3c93
Diff: https://reviews.apache.org/r/70216/diff/4/
Changes: https://reviews.apache.org/r/70216/diff/3-4/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
It would lead to
> > simpler dispatch in the wrapper around the process, and probably be more in
> > line with the way we usually lay this out.
>
> Chun-Hung Hsiao wrote:
> Yes I agree doing what you suggested is more consistent with the existing
> codebase.
>
/provider_process.hpp
a5536b3d735e01eb1c4dc52d0602d973155f3c93
Diff: https://reviews.apache.org/r/70168/diff/8/
Changes: https://reviews.apache.org/r/70168/diff/7-8/
Testing
---
Testing done later in chain.
Thanks,
Chun-Hung Hsiao
://reviews.apache.org/r/70217/diff/3-4/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
a5536b3d735e01eb1c4dc52d0602d973155f3c93
Diff: https://reviews.apache.org/r/70215/diff/3/
Changes: https://reviews.apache.org/r/70215/diff/2-3/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
fea623c292158deb1b4b4b9ab1ac208031471519
src/resource_provider/storage/provider_process.hpp
a5536b3d735e01eb1c4dc52d0602d973155f3c93
Diff: https://reviews.apache.org/r/70216/diff/3/
Changes: https://reviews.apache.org/r/70216/diff/2-3/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
://reviews.apache.org/r/70214/diff/3/
Changes: https://reviews.apache.org/r/70214/diff/2-3/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
side-effect free. WDYT?
- Chun-Hung
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70216/#review213840
---
On March 15, 2019, 5:17 a.m., Chun-Hung Hsiao wrote:
>
> -
>
> >
> > `Option`?
It's already an `Option`. Dropping.
- Chun-Hung
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70216/#review213840
--------
his when we actually send the operation in
> > `_attachVolume`? I am worrying about the potential of interleaved,
> > multistep transitions.
> >
> > Here and in all other handlers.
>
> Chun-Hung Hsiao wrote:
> All of the methods prepended with an underscore
).
That said, let me also do logging in the public-facing functions where
interaction happens. This should give us enough but not too excessive logging
for debugging.
- Chun-Hung
---
This is an automatically generated e-mai
avoid such a race
before issuing the CSI call:
```
if (creating.contanis(name)) {
return Failure("Volume with name '" + name + "' is being created");
}
```
Similar safe-guards should be implemented for `validateVolume` and
`deleteVolume` as well.
- Chu
UNREACHABLE();
});
```
- Chun-Hung
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70214/#review213804
---
On Ma
src/tests/disk_profile_adaptor_tests.cpp
0ccbc79d7ffb82a68b7ed5aeab930bcd8e6e770e
Diff: https://reviews.apache.org/r/70248/diff/2/
Changes: https://reviews.apache.org/r/70248/diff/1-2/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
src/tests/csi_utils_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/70258/diff/1/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
/utils.cpp fd6f95d88caf69e2ae197cf940beb93c164565bc
Diff: https://reviews.apache.org/r/70247/diff/2/
Changes: https://reviews.apache.org/r/70247/diff/1-2/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
example, the "ordering may not
matter" constraint here (although it's not implemented). Also, do we want to
compare unknown fields?
If we want a complete message equality check, then yes I'll just use
`MessageDifferencer`.
- Chun-Hung
--------
rg/r/70213/diff/2/?file=2132466#file2132466line44>
> >
> > `#include `
I intentionally don't want to use `errorbase.hpp` as `error.hpp` seems to be a
more proper public header for inclusion. Dropping. Feel free to reopen.
- Chun-Hung
------
/uri_disk_profile_adaptor.cpp
cb574be2a4b4e443248b2001f822d739e5bbe7b9
src/tests/disk_profile_adaptor_tests.cpp
0ccbc79d7ffb82a68b7ed5aeab930bcd8e6e770e
Diff: https://reviews.apache.org/r/70248/diff/1/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
d07
src/csi/compat.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/70247/diff/1/
Testing
---
Thanks,
Chun-Hung Hsiao
-Hung Hsiao
hun-Hung
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70169/#review213801
---
On March 12, 2019, 8:43 p.m., Chun-Hung Hsiao wrote:
>
to use
metrics.csi_plugin_container_termination instead of
metrics.csiPluginMetrics.container_termination. WDYT?
- Chun-Hung Hsiao
On March 20, 2019, 5:27 a.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
.
Thanks,
Chun-Hung Hsiao
t` function already
returns a failure. Dropping.
- Chun-Hung
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70168/#review213774
------
---
make check
Thanks,
Chun-Hung Hsiao
metrics for running containers.
However, the number of running containers is tightly coupled with whether the
RP would launch a single plugin container (unified CSI deployment) or two
containers (split-component deployment). And that means potentially the
monitoring configuration using this metr
ed unnecessary. And in the code base we mostly only do
`explicit` for constructors with one argument, with very few exceptions. So I'm
fine removing it.
- Chun-Hung
---
This is an automatically generated e-mail. To reply, v
://reviews.apache.org/r/70232/diff/1/
Testing
---
`make check`
Thanks,
Chun-Hung Hsiao
src/csi/v0_volume_manager.cpp PRE-CREATION
src/csi/v0_volume_manager_process.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/70217/diff/3/
Changes: https://reviews.apache.org/r/70217/diff/2-3/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
/storage_local_resource_provider_tests.cpp
7945384867f26fa15dc734a235ae509d5d6d350f
Diff: https://reviews.apache.org/r/70225/diff/1/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
,
Chun-Hung Hsiao
a5536b3d735e01eb1c4dc52d0602d973155f3c93
src/tests/storage_local_resource_provider_tests.cpp
7945384867f26fa15dc734a235ae509d5d6d350f
Diff: https://reviews.apache.org/r/70222/diff/1/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
://reviews.apache.org/r/70215/diff/1-2/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
------
On March 2, 2019, 1:04 a.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70084/
> ---
ment regarding taskGroup would be appreaciated.
Can you elaborated more on what should be clarified?
- Chun-Hung
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70084/#review213740
-
.
Diffs
-
src/csi/v0_volume_manager.cpp PRE-CREATION
src/csi/v0_volume_manager_process.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/70215/diff/1/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
/v0_volume_manager.cpp PRE-CREATION
src/csi/v0_volume_manager_process.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/70217/diff/1/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
`publishVolume`
design, the recovery logic is now simpler.
Diffs
-
src/csi/v0_volume_manager.cpp PRE-CREATION
src/csi/v0_volume_manager_process.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/70216/diff/1/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
/v0_volume_manager.hpp PRE-CREATION
src/csi/v0_volume_manager.cpp PRE-CREATION
src/csi/v0_volume_manager_process.hpp PRE-CREATION
src/csi/volume_manager.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/70214/diff/1/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
---
`make check`
Thanks,
Chun-Hung Hsiao
fea623c292158deb1b4b4b9ab1ac208031471519
src/resource_provider/storage/provider_process.hpp
a5536b3d735e01eb1c4dc52d0602d973155f3c93
Diff: https://reviews.apache.org/r/70169/diff/2/
Changes: https://reviews.apache.org/r/70169/diff/1-2/
Testing
---
sudo make check
Thanks,
Chun-Hung
/metrics.cpp PRE-CREATION
src/csi/service_manager.hpp PRE-CREATION
src/csi/service_manager.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/70168/diff/4/
Changes: https://reviews.apache.org/r/70168/diff/3-4/
Testing
---
Testing done later in chain.
Thanks,
Chun-Hung Hsiao
-CREATION
src/csi/service_manager.hpp PRE-CREATION
src/csi/service_manager.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/70168/diff/3/
Changes: https://reviews.apache.org/r/70168/diff/2-3/
Testing
---
Testing done later in chain.
Thanks,
Chun-Hung Hsiao
a5536b3d735e01eb1c4dc52d0602d973155f3c93
Diff: https://reviews.apache.org/r/70169/diff/1/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
/
Testing
---
Testing done later in chain.
Thanks,
Chun-Hung Hsiao
this in the future, I'd suggest
we split the fix and the tests in two patches :)
- Chun-Hung Hsiao
On March 8, 2019, 1:34 p.m., Jan Schlicht wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70132/#review213538
-------
On March 8, 2019, 12:23 a.m., Chun-Hung Hsiao wrote:
>
> -
/slave_tests.cpp 5ee5609af0861e9aecf02a5eaefafe137bd9b843
Diff: https://reviews.apache.org/r/70132/diff/3/
Changes: https://reviews.apache.org/r/70132/diff/2-3/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
have `src/master/http.hpp` lol.
src/master/http.cpp
Lines 3991-4003 (patched)
<https://reviews.apache.org/r/70154/#comment299483>
We can use `protobuf::getConsumedResources` instead.
- Chun-Hung Hsiao
On March 7, 2019, 1:41 p.m., Benjamin Bannier
Diff: https://reviews.apache.org/r/70135/diff/1/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
quot;
- Chun-Hung
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70135/#review213459
---
On March 6, 2019, 5:10 a.m., Ch
make check
Thanks,
Chun-Hung Hsiao
/slave_tests.cpp 22a0295086ae4f4ec26df00a0e077eecfa27f1fb
Diff: https://reviews.apache.org/r/70132/diff/2/
Changes: https://reviews.apache.org/r/70132/diff/1-2/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
ttps://reviews.apache.org/r/70132/#review213453
---
On March 6, 2019, 12:53 a.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-mail. To reply, vis
of the three modified tests finishes in 5 seconds.
Thanks,
Chun-Hung Hsiao
6cdfe97360c6e2a91b71f03efb0c29998e2d4b9f
Diff: https://reviews.apache.org/r/70134/diff/1/
Testing
---
`make check`
Run the test in repetition.
Thanks,
Chun-Hung Hsiao
/1/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
/diff/3/
Changes: https://reviews.apache.org/r/69970/diff/2-3/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
a hard error to me (but would introduce
> > coupling). Maybe just inline the function here and possibly assert.
>
> Chun-Hung Hsiao wrote:
> This definitely means the csidir is somehow "damaged." But the agent can
> operate without it, and the failure would fail
7ad495504e4ff144ac31812fbd4a3a1f4da86f02
src/slave/slave.cpp e3c2c005d865b5c333e92e50e49ef398fe06ad79
Diff: https://reviews.apache.org/r/70081/diff/4/
Changes: https://reviews.apache.org/r/70081/diff/3-4/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
`
- Chun-Hung
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70081/#review213392
---
On March 1, 2019, 11:46 p.m., Chun-H
://reviews.apache.org/r/69955/diff/1-2/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
://reviews.apache.org/r/69954/diff/1-2/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
y generated e-mail. To reply, visit:
https://reviews.apache.org/r/69588/#review213385
---
On March 3, 2019, 6:21 a.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically
Thanks,
Chun-Hung Hsiao
becomes outdated. This patch cleans it up.
Diffs (updated)
-
src/master/master.cpp 015da54583448a8d102d8e401e48bd228baf6dd6
Diff: https://reviews.apache.org/r/69588/diff/3/
Changes: https://reviews.apache.org/r/69588/diff/2-3/
Testing
---
sudo make check
Thanks,
Chun-Hung
/mesos/mesos.proto#L1233.
- Chun-Hung
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69588/#review212376
---
On Dec. 19, 2018, 11:20 p.m., Chun-Hung Hsiao wrote:
>
> -
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69588/#review212027
---
On Dec. 19, 2018, 11:20 p.m., Chun-Hung Hsiao wrote:
>
> -
iff/2/?file=2115120#file2115120line3734>
> >
> > Is the empty case valid?
> >
> > Also, use `Resources::reservationRole`?
See above.
- Chun-Hung
---
This is an automatically generated
7ad495504e4ff144ac31812fbd4a3a1f4da86f02
src/slave/slave.cpp e3c2c005d865b5c333e92e50e49ef398fe06ad79
Diff: https://reviews.apache.org/r/70084/diff/1/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
: https://reviews.apache.org/r/70082/diff/1-2/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
src/slave/slave.cpp e3c2c005d865b5c333e92e50e49ef398fe06ad79
Diff: https://reviews.apache.org/r/70081/diff/3/
Changes: https://reviews.apache.org/r/70081/diff/2-3/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
://reviews.apache.org/r/70080/diff/1-2/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
ail. To reply, visit:
https://reviews.apache.org/r/70082/#review213336
---
On March 1, 2019, 8:10 p.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically genera
nerated e-mail. To reply, visit:
https://reviews.apache.org/r/70081/#review213337
-------
On March 1, 2019, 8:11 p.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.ap
7ad495504e4ff144ac31812fbd4a3a1f4da86f02
src/slave/slave.cpp e3c2c005d865b5c333e92e50e49ef398fe06ad79
Diff: https://reviews.apache.org/r/70081/diff/2/
Changes: https://reviews.apache.org/r/70081/diff/1-2/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
://reviews.apache.org/r/70082/diff/1/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
: https://reviews.apache.org/r/70081/diff/1/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
201 - 300 of 1959 matches
Mail list logo
