Re: Review Request 35857: Added Acknowledge call support to the master and the C++ scheduler library.

2015-06-25 Thread Isabel Jimenez
/35857/#comment141992 Is the purpose of moving this here to order Call handling methods? if yes, should we move revive too? - Isabel Jimenez On June 25, 2015, 1:11 a.m., Vinod Kone wrote: --- This is an automatically generated e-mail

Re: Review Request 35770: Consistent 'Test' suffix in mesos test names.

2015-06-23 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35770/#review89087 --- Ship it! Ship It! - Isabel Jimenez On June 23, 2015, 1:21 p.m

Re: Review Request 35769: Consistent 'Test' suffix in libprocess test names.

2015-06-23 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35769/#review89088 --- Ship it! Ship It! - Isabel Jimenez On June 23, 2015, 7:06 a.m

Re: Review Request 35768: Consistent 'Test' suffix in stout test names.

2015-06-23 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35768/#review89089 --- Ship it! Ship It! - Isabel Jimenez On June 23, 2015, 7:05 a.m

Re: Review Request 35752: Added stub Event protobuf handler to scheduler driver.

2015-06-23 Thread Isabel Jimenez
/#comment141687 Aren't we using braces on switch cases syntax? like: ``` switch (type) { case ENUM: { break } } ``` - Isabel Jimenez On June 23, 2015, 7:26 p.m., Ben Mahler wrote

Re: Review Request 35538: [MESOS-1988] Remove unused drop(...) overload

2015-06-16 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35538/#review88137 --- Ship it! Ship It! - Isabel Jimenez On June 16, 2015, 9:44 p.m

Re: Review Request 35506: Excluding MarkDown files from the style hook

2015-06-16 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35506/#review88176 --- Ship it! Ship It! - Isabel Jimenez On June 16, 2015, 11:24 a.m

Re: Review Request 30952: Adding scheduler validations to master

2015-06-09 Thread Isabel Jimenez
with new HTTP API endpoints tests. Thanks, Isabel Jimenez

Re: Review Request 30952: Adding scheduler validations to master

2015-06-09 Thread Isabel Jimenez
and distcheck. Tests will be added with new HTTP API endpoints tests. Thanks, Isabel Jimenez

Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

2015-06-01 Thread Isabel Jimenez
On June 1, 2015, 5:59 p.m., Chi Zhang wrote: src/linux/routing/queueing/ingress.cpp, lines 44-51 https://reviews.apache.org/r/34830/diff/2/?file=975053#file975053line44 Two blank lines between the functions. here and other places. Since the functions are inside a

Re: Review Request 34830: Fix routing ingress/fq_codel search returning wrong qdisc.

2015-05-30 Thread Isabel Jimenez
reinterpret_cast here? am I missing something that needs changing the bit interpretation of this in the machine? src/linux/routing/queueing/internal.hpp https://reviews.apache.org/r/34830/#comment137666 same as above - Isabel Jimenez On May 29, 2015, 9:57 p.m., Paul Brett wrote

Re: Review Request 33871: Added /teardown endpoint that is going to replace /shutdown endpoint.

2015-05-06 Thread Isabel Jimenez
the framework.), ``` - Isabel Jimenez On May 6, 2015, 5:14 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33871

Re: Review Request 33871: Added /teardown endpoint that is going to replace /shutdown endpoint.

2015-05-06 Thread Isabel Jimenez
On May 6, 2015, 8:41 p.m., Isabel Jimenez wrote: Besides this, LGTM! - Isabel --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33871/#review82727

Re: Review Request 33872: Renamed shutdown_tests.cpp to teardown_tests.cpp.

2015-05-06 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33872/#review82725 --- Ship it! LGTM! - Isabel Jimenez On May 6, 2015, 5:15 p.m

Re: Review Request 33871: Added /teardown endpoint that is going to replace /shutdown endpoint.

2015-05-06 Thread Isabel Jimenez
/#comment133530 same as above - Isabel Jimenez On May 6, 2015, 5:14 p.m., Vinod Kone wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33871

<    1   2   3