Re: Review Request 34129: Add 2 optional args public_ip and public_port for libprocess to advertise.

2015-05-12 Thread Jay Buffington
: https://github.com/apache/mesos/blob/b2b03/src/master/http.cpp#L397-L398 Also, it would be super helpful to write a summary of how to use this feature to run mesos behind a proxy. This could go in docs/operational-guide.md - Jay Buffington On May 12, 2015, 4:30 p.m., Anindya Sinha wrote

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

2015-05-11 Thread Jay Buffington
On May 11, 2015, 3:06 p.m., Jay Buffington wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33249/ > --- > > (

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

2015-05-11 Thread Jay Buffington
ee3c9e7fc38ad364e83f4abe267e86bfbbc13 src/tests/docker_containerizer_tests.cpp c9d66b3fbc7d081f36c26781573dca50de823c44 Diff: https://reviews.apache.org/r/33249/diff/ Testing --- I used examples/docker_no_executor_framework.cpp, and wrote a few tests and ran make check Thanks, Jay Buffington

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

2015-05-11 Thread Jay Buffington
esos/containerizer.hpp > 5e5f13ed8a71ff9510b40b6032d00fd16d312622 > src/slave/containerizer/mesos/containerizer.cpp > f2587280dc0e1d566d2b856a80358c7b3896c603 > src/slave/slave.cpp c78ee3c9e7fc38ad364e83f4abe267e86bfbbc13 > src/tests/docker_containerizer_tests.cpp > c9d66b3fbc7d081f36c26781573dca50de823c44 > src/tests/slave_tests.cpp 04e79ec061e767a82d40242be7884967942c50b6 > > Diff: https://reviews.apache.org/r/33249/diff/ > > > Testing > --- > > I used examples/docker_no_executor_framework.cpp, and wrote a few tests and > ran make check > > > Thanks, > > Jay Buffington > >

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

2015-05-11 Thread Jay Buffington
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33249/#review83233 ------- On May 11, 2015, 10:10 a.m., Jay Buffington wrote: > > --

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

2015-05-11 Thread Jay Buffington
iews.apache.org/r/33249/diff/ Testing --- I used examples/docker_no_executor_framework.cpp, and wrote a few tests and ran make check Thanks, Jay Buffington

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

2015-05-11 Thread Jay Buffington
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33249/#review83136 ----------- On May 8, 2015, 7:42 p.m., Jay Buffington wrote: > >

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

2015-05-08 Thread Jay Buffington
d566d2b856a80358c7b3896c603 src/slave/slave.cpp c78ee3c9e7fc38ad364e83f4abe267e86bfbbc13 src/tests/docker_containerizer_tests.cpp c9d66b3fbc7d081f36c26781573dca50de823c44 Diff: https://reviews.apache.org/r/33249/diff/ Testing (updated) --- I used examples/docker_no_executor_framework.cpp, and wr

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

2015-05-07 Thread Jay Buffington
setting it) was much less straight forward than I expected it to be. I talked to Jörg about this and he said he was willing to take it on next week. I'll note it here and reference MESOS-2035. - Jay ------- This is a

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

2015-05-07 Thread Jay Buffington
g/r/33249/diff/ Testing --- I used examples/docker_no_executor_framework.cpp and make check Thanks, Jay Buffington

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

2015-05-07 Thread Jay Buffington
ff/4/?file=952339#file952339line3125> > > > > We shouldn't need to destroy if none of the containerizers return true. Ah, that's right. I will just remove this line. - Jay ------- This is an au

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

2015-05-07 Thread Jay Buffington
diff/ Testing (updated) --- I used examples/docker_no_executor_framework.cpp and make check Thanks, Jay Buffington

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

2015-05-06 Thread Jay Buffington
good, I think what you proposed makes sense, in > docker containerizer at least we also need to make sure termination message > is set correctly as currently it doesn't contain all the error information > that we pass back to the launch future. > > Jay Buffington wrote: >

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

2015-05-05 Thread Jay Buffington
good, I think what you proposed makes sense, in > docker containerizer at least we also need to make sure termination message > is set correctly as currently it doesn't contain all the error information > that we pass back to the launch future. > > Jay Buffington wrote: >

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

2015-05-04 Thread Jay Buffington
good, I think what you proposed makes sense, in > docker containerizer at least we also need to make sure termination message > is set correctly as currently it doesn't contain all the error information > that we pass back to the launch future. > > Jay Buffington wrote: >

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

2015-04-30 Thread Jay Buffington
good, I think what you proposed makes sense, in > docker containerizer at least we also need to make sure termination message > is set correctly as currently it doesn't contain all the error information > that we pass back to the launch future. > > Jay Buffington wrote: >

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

2015-04-22 Thread Jay Buffington
good, I think what you proposed makes sense, in > docker containerizer at least we also need to make sure termination message > is set correctly as currently it doesn't contain all the error information > that we pass back to the launch future. > > Jay Buffington wrote: >

Re: Review Request 33249: Send statusUpdate to scheduler on containerizer launch failure

2015-04-22 Thread Jay Buffington
issues, but the key is that when the containerizer launch fails we have to send a statusUpdate with a message that contains future.failure(). Before this patch we were only logging it. The scheduler needs to get that error message. - Jay ---------