Re: Review Request 35510: Introduced General and Markdown Documentation Style Guides.

/35510/diff/ Testing --- Rendered Version: Documentation Guide: https://gist.github.com/joerg84/9d1821b745ae8c8f289e Markdown Guide: https://gist.github.com/joerg84/218eb38e066b35a6e25e Thanks, Joerg Schad

Re: Review Request 35494: Added format for template declaration in the styleguide.

it this way. Most other code I know omits the space. Still, as this seems to be common practice... docs/mesos-c++-style-guide.md (line 62) https://reviews.apache.org/r/35494/#comment140439 Why is this under Class Format? Can't we have: ### Template * Leave - Joerg Schad On June 16

Re: Review Request 35350: Fixes markdown of the Doxygen Styleguide to provide better rendering.

/. - Joerg Schad On June 11, 2015, 11:59 a.m., Alexander Rojas wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35350/ --- (Updated

Re: Review Request 35207: Included doxygen documentation in docs/home.md.

/ Testing --- Thanks, Joerg Schad

Re: Review Request 35206: Added mainpage to doxygen documentation.

://reviews.apache.org/r/35206/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 35206: Added mainpage to doxygen documentation.

://reviews.apache.org/r/35206/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 35206: Added mainpage to doxygen documentation.

Diff: https://reviews.apache.org/r/35206/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 35131: Replaced os::dirname and os::basename with Path::dirname and Path::basename.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35131/#review86869 --- Ship it! Ship It! - Joerg Schad On June 5, 2015, 1:20 p.m

Re: Review Request 33331: Added file headers section to the C++ style guide.

/#comment138668 Please make this a list item (same below). pmust or should?/p docs/mesos-c++-style-guide.md https://reviews.apache.org/r/1/#comment138669 must or should? - Joerg Schad On June 4, 2015, 2:37 p.m., Till Toenshoff wrote

Re: Review Request 35000: Doxygen'ized Subprocess.

/returns/return same for rest of file Great effort, makes understanding Subprocess much simpler! - Joerg Schad On June 3, 2015, 1:45 p.m., Benjamin Hindman wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 34565: Allowed explicitly-defaulted functions in styleguide.

cb45beb98527daa338a98e8a8b6a30730f881c43 Diff: https://reviews.apache.org/r/34565/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 34939: Started Doxygen Style-Guide.

--- Thanks, Joerg Schad

Re: Review Request 34563: Allowed delegating constructors in styleguide.

/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 34534: Reflected in documentation that isolators are only relevant for Mesos Containerizer.

/flags.cpp b5e25186dad36bc1306cc6ecb268aba951a18f7e Diff: https://reviews.apache.org/r/34534/diff/ Testing --- Thanks, Joerg Schad

Review Request 34565: Allowed explicitly-defaulted functions in styleguide.

--- Thanks, Joerg Schad

Review Request 34563: Allowed delegating constructors in styleguide

Description --- Allowed delegating constructors in styleguide Diffs - docs/mesos-c++-style-guide.md 13312f6f4fe1788791479bd768f60df0a8e80e69 Diff: https://reviews.apache.org/r/34563/diff/ Testing --- Thanks, Joerg Schad

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

On May 20, 2015, 7:18 a.m., Joerg Schad wrote: docs/powered-by-mesos.md, line 28 https://reviews.apache.org/r/33295/diff/4/?file=947287#file947287line28 Is that dropped by a rebase or by you? Same below Thanks for fixing this so quickly :-). - Joerg

Re: Review Request 33514: Wired up --allocator flag in master.

On May 8, 2015, 8:58 p.m., Joerg Schad wrote: Please add to documentation After that Ship it! - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33514/#review83085

Re: Review Request 33276: Fix capture by reference of temporaries in Libprocess.

does not cause a noticable performance penalty (don't think so, but numbers are always good to verify) - Joerg Schad On April 22, 2015, 6:11 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 33733: Fixed style error with template definitions withing common/parse.hpp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33733/#review82876 --- Ship it! Ship It! - Joerg Schad On April 30, 2015, 10:45 p.m

Re: Review Request 33274: Fix capture by reference of temporary strings in Libprocess.

. - Joerg Schad On April 22, 2015, 6:11 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33274

Re: Review Request 32198: Added a not equal operator for json objects.

On May 7, 2015, 8:07 p.m., Joerg Schad wrote: configure.ac, line 566 https://reviews.apache.org/r/32198/diff/7/?file=952552#file952552line566 How is this related to your change? Looking at the review history could it be that this was added by mistake? - Joerg

Re: Review Request 33358: Moved implementation of StatusUpdateStream to a compilation unit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33358/#review82897 --- Ship it! Ship It! - Joerg Schad On April 22, 2015, 9:09 a.m

Re: Review Request 33733: Fixed style error with template definitions withing common/parse.hpp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33733/#review82563 --- LGTM - Joerg Schad On April 30, 2015, 10:45 p.m., Alexander

<    6   7   8   9   10   11