Re: Review Request 43269: MasterContender/MasterDetector loadable as modules.

2016-02-19 Thread Mark Cavage
unit tests passing, we are currently using this functionality in our environment with a custom consensus stack. In our world, we have a C++ plugin that calls out to an HTTP REST service (implemented in Java/Scala, not that it matters). Thanks, Mark Cavage

Re: Review Request 43269: MasterContender/MasterDetector loadable as modules.

2016-02-19 Thread Mark Cavage
n try to load a plugin. This should be the least disruptive behavior (imo), and module authors don't need to worry about anything else "legacy." - Mark --- This is an automatically generated e-mail. To reply, visit: https://re

Re: Review Request 43269: MasterContender/MasterDetector loadable as modules.

2016-02-18 Thread Mark Cavage
/diff/ Testing --- In addition to all unit tests passing, we are currently using this functionality in our environment with a custom consensus stack. In our world, we have a C++ plugin that calls out to an HTTP REST service (implemented in Java/Scala, not that it matters). Thanks,

Re: Review Request 43269: MasterContender/MasterDetector loadable as modules.

2016-02-17 Thread Mark Cavage
this functionality in our environment with a custom consensus stack. In our world, we have a C++ plugin that calls out to an HTTP REST service (implemented in Java/Scala, not that it matters). Thanks, Mark Cavage

Re: Review Request 43269: MasterContender/MasterDetector loadable as modules.

2016-02-17 Thread Mark Cavage
there's precedence. Changed back to using `Option`. - Mark --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43269/#review119232 -------

Re: Review Request 43269: MasterContender/MasterDetector loadable as modules.

2016-02-17 Thread Mark Cavage
using this functionality in our environment with a custom consensus stack. In our world, we have a C++ plugin that calls out to an HTTP REST service (implemented in Java/Scala, not that it matters). Thanks, Mark Cavage

Review Request 43269: MasterContender/MasterDetector loadable as modules.

2016-02-05 Thread Mark Cavage
world, we have a C++ plugin that calls out to an HTTP REST service (implemented in Java/Scala, not that it matters). Thanks, Mark Cavage