----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62919/ -----------------------------------------------------------
Review request for mesos and Joseph Wu. Bugs: MESOS-7935 https://issues.apache.org/jira/browse/MESOS-7935 Repository: mesos Description (updated) ------- Added check to prevent in-source build. With this change, I think it makes sense to add to the CMake documentation page that in-source builds are not supported. Unfortunately, if you try to build in-source, cmake still generates a CMakeCache.txt file and CMakeFiles/ folder and it stops out of source builds. Might be useful to say what should be cleaned up in the event someone tries to do an in-source build. Testing (updated) ------- Testing performed on Fedora 26. Attempted to build in-source, verified that the cmake step fails. Attempted to build out of source, verified build works. Thanks, Nathan Jackson