bmahler closed pull request #556: [cgroups2] Implement Cgroups 2 isolator w/o
nested containers and systemd.
URL: https://github.com/apache/mesos/pull/556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
bmahler commented on code in PR #556:
URL: https://github.com/apache/mesos/pull/556#discussion_r1575260114
##
src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.cpp:
##
@@ -120,6 +144,622 @@ bool Cgroups2IsolatorProcess::supportsStandalone()
return true;
}
+
DevinLeamy commented on code in PR #556:
URL: https://github.com/apache/mesos/pull/556#discussion_r1572831258
##
src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.cpp:
##
@@ -120,6 +144,569 @@ bool Cgroups2IsolatorProcess::supportsStandalone()
return true;
}
+
DevinLeamy commented on code in PR #556:
URL: https://github.com/apache/mesos/pull/556#discussion_r1569570036
##
src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.cpp:
##
@@ -120,6 +144,569 @@ bool Cgroups2IsolatorProcess::supportsStandalone()
return true;
}
+
DevinLeamy commented on code in PR #556:
URL: https://github.com/apache/mesos/pull/556#discussion_r1569562534
##
src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.cpp:
##
@@ -120,6 +144,569 @@ bool Cgroups2IsolatorProcess::supportsStandalone()
return true;
}
+
DevinLeamy commented on code in PR #556:
URL: https://github.com/apache/mesos/pull/556#discussion_r1569553390
##
src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.hpp:
##
@@ -32,6 +35,23 @@ namespace mesos {
namespace internal {
namespace slave {
+// Cgroups v2
DevinLeamy commented on PR #556:
URL: https://github.com/apache/mesos/pull/556#issuecomment-2062130720
Renamed "domain cgroup" to "non-leaf cgroup". Added a comment with a diagram
to the Cgroups2IsolatorProcess header to illustrate the cgroup structure for a
container.
--
This is an