Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-15 Thread Michael Park
On June 15, 2015, 5:28 p.m., Jojy Varghese wrote: 3rdparty/libprocess/include/process/address.hpp, line 84 https://reviews.apache.org/r/29406/diff/29/?file=984330#file984330line84 There are a few if family == INET (or similar) in the code. By specializing the net address

Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-14 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/#review87858 --- Ship it! This looks good Joris! Thans for all the hard work,

Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-14 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/#review87885 --- 3rdparty/libprocess/include/process/address.hpp

Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-13 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/#review87834 --- Ship it! Ship It! - Michael Park On June 13, 2015, 9:23 a.m.,

Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-13 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/ --- (Updated June 13, 2015, 7:13 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-13 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/#review87783 --- Reviewed `libevent_ssl_socket.{hpp,cpp}`. I don't have much

Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-13 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/ --- (Updated June 13, 2015, 8:27 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-13 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/ --- (Updated June 13, 2015, 8:47 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-13 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/ --- (Updated June 13, 2015, 9:23 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-12 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/ --- (Updated June 12, 2015, 6:06 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-12 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/#review87735 --- Are the changes to process.cpp, libevent.{hpp|cpp} independent?

Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-12 Thread Benjamin Hindman
On June 12, 2015, 6:17 p.m., Ben Mahler wrote: Are the changes to process.cpp, libevent.{hpp|cpp} independent? Hard to tell if these are related to SSL, can you pull them out into separate reviews? Ben: I've been reviewing this closely with Joris and asked him to keep these in the

Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-12 Thread Ben Mahler
On June 12, 2015, 6:17 p.m., Ben Mahler wrote: Are the changes to process.cpp, libevent.{hpp|cpp} independent? Hard to tell if these are related to SSL, can you pull them out into separate reviews? Benjamin Hindman wrote: Ben: I've been reviewing this closely with Joris and

Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-11 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/ --- (Updated June 11, 2015, 2:57 p.m.) Review request for Benjamin Hindman and

Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/ --- (Updated June 9, 2015, 3:09 p.m.) Review request for Benjamin Hindman and

Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/ --- (Updated June 9, 2015, 1:29 p.m.) Review request for Benjamin Hindman and

Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-08 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/ --- (Updated June 8, 2015, 5:48 p.m.) Review request for Michael Park. Changes

Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-08 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/ --- (Updated June 8, 2015, 12:58 p.m.) Review request for Michael Park. Changes

Re: Review Request 29406: Introduce libevent ssl socket.

2015-05-29 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/ --- (Updated May 30, 2015, 5:29 a.m.) Review request for Michael Park. Changes