Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.

2015-09-14 Thread Joris Van Remoortere
> On Aug. 31, 2015, 7:49 a.m., Jian Qiu wrote: > > src/master/master.cpp, line 4904 > > > > > > If the allocator calls inverse callback followed by an offer callback, > > will the two messages be handled in two

Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.

2015-09-13 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37180/ --- (Updated Sept. 13, 2015, 8:33 p.m.) Review request for mesos, Benjamin

Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.

2015-09-09 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37180/#review98187 --- Ship it! Ship It! - Yong Qiao Wang On Sept. 2, 2015, 7:32 p.m.,

Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.

2015-09-02 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37180/ --- (Updated Sept. 2, 2015, 7:32 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.

2015-08-31 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37180/#review97064 --- src/master/master.cpp (line 4904)

Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.

2015-08-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37180/#review96393 --- Ship it! Ship It! - Guangya Liu On Aug. 25, 2015, 2:13 a.m.,

Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.

2015-08-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37180/ --- (Updated Aug. 26, 2015, 2:13 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.

2015-08-24 Thread Joris Van Remoortere
On Aug. 12, 2015, 9:16 p.m., Joseph Wu wrote: Why are the InverseOffers (and Offers) hashed as pointers? Can you point to an example. I don't understand your question. - Joris --- This is an automatically generated e-mail. To reply,

Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.

2015-08-24 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37180/ --- (Updated Aug. 25, 2015, 2:13 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.

2015-08-18 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37180/#review95786 --- Ship it! LGTM. src/master/master.cpp (line 5745)

Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.

2015-08-18 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37180/#review95803 --- src/master/master.cpp (line 4145)

Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.

2015-08-12 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37180/#review95172 --- Why are the InverseOffers (and Offers) hashed as pointers?

Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.

2015-08-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37180/ --- (Updated Aug. 10, 2015, 7:05 a.m.) Review request for mesos, Benjamin Hindman,