Re: Review Request 39098: Changed secret field in Credential from 'bytes' to 'string'

2015-10-13 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39098/ --- (Updated Oct. 13, 2015, 7:53 a.m.) Review request for mesos and Michael Park.

Re: Review Request 39098: Changed secret field in Credential from 'bytes' to 'string'

2015-10-13 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39098/#review102409 --- src/tests/credentials_tests.cpp (line 116)

Re: Review Request 39098: Changed secret field in Credential from 'bytes' to 'string'

2015-10-13 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39098/ --- (Updated Oct. 13, 2015, 8:45 a.m.) Review request for mesos and Michael Park.

Re: Review Request 39098: Changed secret field in Credential from 'bytes' to 'string'

2015-10-13 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39098/#review102411 --- Ship it! I added the comments to the test you added, but some of

Re: Review Request 39098: Changed secret field in Credential from 'bytes' to 'string'

2015-10-13 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39098/#review102420 --- Ship it! I've committed this with the following minor style

Re: Review Request 39098: Changed secret field in Credential from 'bytes' to 'string'

2015-10-09 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39098/#review102043 --- Ship it! Ship It! - Till Toenshoff On Oct. 8, 2015, 1 a.m.,

Re: Review Request 39098: Changed secret field in Credential from 'bytes' to 'string'

2015-10-07 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39098/ --- (Updated Oct. 8, 2015, 1 a.m.) Review request for mesos and Michael Park.