Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

2015-11-18 Thread James Peach
> On Nov. 11, 2015, 9:28 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, lines 4244-4247 > > > > > > why do it here instead of in recoverFramework() #4363? that feels more > > consistent with #1345. > > James

Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

2015-11-18 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40177/ --- (Updated Nov. 18, 2015, 6:49 p.m.) Review request for mesos, Kapil Arya and

Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

2015-11-18 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40177/#review107070 --- src/slave/slave.cpp (line 4321)

Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

2015-11-18 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40177/ --- (Updated Nov. 18, 2015, 9:56 p.m.) Review request for mesos, Kapil Arya and

Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

2015-11-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40177/#review107087 --- Patch looks great! Reviews applied: [40177] Passed command:

Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

2015-11-17 Thread Vinod Kone
> On Nov. 11, 2015, 9:28 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, lines 4244-4247 > > > > > > why do it here instead of in recoverFramework() #4363? that feels more > > consistent with #1345. > > James

Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

2015-11-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40177/#review106061 --- Ship it! Ship It! - Guangya Liu On εδΈ€ζœˆ 11, 2015, 5:59 a.m.,

Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

2015-11-11 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40177/ --- (Updated Nov. 12, 2015, 5:41 a.m.) Review request for mesos, Kapil Arya and

Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

2015-11-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40177/#review106200 --- Patch looks great! Reviews applied: [40177] All tests passed. -

Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

2015-11-11 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40177/#review106142 --- src/slave/slave.cpp (lines 4244 - 4247)

Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

2015-11-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40177/#review106018 --- Patch looks great! Reviews applied: [40177] All tests passed. -

Re: Review Request 40177: Re-checkpoint frameworks after agent recovery.

2015-11-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40177/#review106020 --- Patch looks great! Reviews applied: [40177] All tests passed. -