Re: Review Request 41791: Updated allocation slack when dynamic reserve new resources (1/3).

2016-01-21 Thread Guangya Liu
> On 一月 19, 2016, 11:34 p.m., Joseph Wu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 676 > > > > > > I see several places where you overwrite changes from this review in > > the subsequent two. Did

Re: Review Request 41791: Updated allocation slack when dynamic reserve new resources (1/3).

2016-01-21 Thread Joseph Wu
> On Jan. 20, 2016, 2:54 p.m., Joseph Wu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 662 > > > > > > Have you considered modifying `Resources::apply` to "create" allocation > > slack upon a

Re: Review Request 41791: Updated allocation slack when dynamic reserve new resources (1/3).

2016-01-21 Thread Joseph Wu
> On Jan. 19, 2016, 3:34 p.m., Joseph Wu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 676 > > > > > > I see several places where you overwrite changes from this review in > > the subsequent two.

Re: Review Request 41791: Updated allocation slack when dynamic reserve new resources (1/3).

2016-01-20 Thread Guangya Liu
> On 一月 20, 2016, 10:54 p.m., Joseph Wu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 662 > > > > > > Have you considered modifying `Resources::apply` to "create" allocation > > slack upon a

Re: Review Request 41791: Updated allocation slack when dynamic reserve new resources (1/3).

2016-01-20 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41791/#review115497 --- src/master/allocator/mesos/hierarchical.cpp (line 662)

Re: Review Request 41791: Updated allocation slack when dynamic reserve new resources (1/3).

2016-01-20 Thread Joseph Wu
> On Jan. 19, 2016, 3:34 p.m., Joseph Wu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 676 > > > > > > I see several places where you overwrite changes from this review in > > the subsequent two.

Re: Review Request 41791: Updated allocation slack when dynamic reserve new resources (1/3).

2016-01-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41791/ --- (Updated 一月 20, 2016, 6:38 a.m.) Review request for mesos, Ben Mahler, Artem