Re: Review Request 41861: Fixed a problem of parsing v1Compatibility in Docker v2 image manifest.

2016-01-04 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41861/#review112657 --- Ship it! Ship It!

Re: Review Request 41861: Fixed a problem of parsing v1Compatibility in Docker v2 image manifest.

2016-01-04 Thread Gilbert Song
> On Jan. 4, 2016, 2:06 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp, line > > 257 > > > > > > Should we also CHECK here fslayers_size() == history size?

Re: Review Request 41861: Fixed a problem of parsing v1Compatibility in Docker v2 image manifest.

2016-01-04 Thread Timothy Chen
> On Jan. 4, 2016, 10:06 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp, line > > 257 > > > > > > Should we also CHECK here fslayers_size() == history size? > >

Re: Review Request 41861: Fixed a problem of parsing v1Compatibility in Docker v2 image manifest.

2016-01-04 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41861/#review112655 --- Ship it! Tested and verified that this patch works well. -

Re: Review Request 41861: Fixed a problem of parsing v1Compatibility in Docker v2 image manifest.

2016-01-04 Thread Gilbert Song
> On Jan. 4, 2016, 2:06 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp, line > > 257 > > > > > > Should we also CHECK here fslayers_size() == history size? > >

Re: Review Request 41861: Fixed a problem of parsing v1Compatibility in Docker v2 image manifest.

2016-01-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41861/ --- (Updated Jan. 3, 2016, 6:33 p.m.) Review request for mesos, Gilbert Song, Jojy

Re: Review Request 41861: Fixed a problem of parsing v1Compatibility in Docker v2 image manifest.

2016-01-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41861/#review112475 --- Patch looks great! Reviews applied: [41839, 41840, 41841, 41842,