Re: Review Request 42828: Updated ReviewBot to tee build output to a file.

2016-01-29 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42828/#review116968 --- Fix it, then Ship it! support/verify_reviews.py (line 150)

Re: Review Request 42828: Updated ReviewBot to tee build output to a file.

2016-01-28 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42828/ --- (Updated Jan. 29, 2016, 1:15 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 42828: Updated ReviewBot to tee build output to a file.

2016-01-28 Thread Vinod Kone
> On Jan. 29, 2016, 1:03 a.m., Anand Mazumdar wrote: > > support/verify_reviews.py, line 151 > > > > > > hmm .. what happens to the build_output file thereafter? Should we be > > cleaning it up too? This gets

Re: Review Request 42828: Updated ReviewBot to tee build output to a file.

2016-01-28 Thread Vinod Kone
> On Jan. 29, 2016, 1:10 a.m., Kevin Klues wrote: > > support/verify_reviews.py, line 140 > > > > > > To avoid using tee, you could just do: > > > > "%s > %s 2>&1" % (command, build_output) The above just

Re: Review Request 42828: Updated ReviewBot to tee build output to a file.

2016-01-28 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42828/#review116864 --- Ship it! You would need to update the Summary/Description

Re: Review Request 42828: Updated ReviewBot to tee build output to a file.

2016-01-28 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42828/#review116858 --- support/verify_reviews.py (line 139)

Re: Review Request 42828: Updated ReviewBot to tee build output to a file.

2016-01-28 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42828/#review116850 --- LGTM. Just one minor query about what happens to the piped file

Re: Review Request 42828: Updated ReviewBot to tee build output to a file.

2016-01-28 Thread Kevin Klues
> On Jan. 29, 2016, 1:10 a.m., Kevin Klues wrote: > > support/verify_reviews.py, line 140 > > > > > > To avoid using tee, you could just do: > > > > "%s > %s 2>&1" % (command, build_output) > > Vinod Kone

Re: Review Request 42828: Updated ReviewBot to tee build output to a file.

2016-01-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42828/#review116884 --- Patch looks great! Reviews applied: [42828] Passed command:

Re: Review Request 42828: Updated ReviewBot to tee build output to a file.

2016-01-28 Thread Kevin Klues
> On Jan. 29, 2016, 1:37 a.m., Anand Mazumdar wrote: > > You would need to update the Summary/Description again while committing. > > Probably got erased by not having `--guess_fields=auto`. :-( This is now the default if you use the standard .reviewboardrc https://reviews.apache.org/r/41411/

Re: Review Request 42828: Updated ReviewBot to tee build output to a file.

2016-01-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42828/#review116506 --- Patch looks great! Reviews applied: [42828] Passed command: