Re: Review Request 43358: Added support for all additional Perf Events in PerfEventIsolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43358/#review141544 --- Closing this review due to inactivity. Please see our

Re: Review Request 43358: Added support for all additional Perf Events in PerfEventIsolator.

> On Feb. 10, 2016, 1:41 p.m., Szymon Konefal wrote: > > src/linux/perf.cpp, line 479 > > > > > > Shouldn't we use 'nullptr' instead of NULL? > > Bartek Plotka wrote: > +1 IMO `nullptr` sounds like a good

Re: Review Request 43358: Added support for all additional Perf Events in PerfEventIsolator.

> On Feb. 10, 2016, 1:41 p.m., Szymon Konefal wrote: > > src/linux/perf.cpp, line 479 > > > > > > Shouldn't we use 'nullptr' instead of NULL? +1 IMO `nullptr` sounds like a good choice. All, do you agree with that?

Re: Review Request 43358: Added support for all additional Perf Events in PerfEventIsolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43358/#review118637 --- src/linux/perf.cpp (line 474)

Re: Review Request 43358: Added support for all additional Perf Events in PerfEventIsolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43358/ --- (Updated Feb. 10, 2016, 4:36 p.m.) Review request for mesos, Ben Mahler, Chi

Re: Review Request 43358: Added support for all additional Perf Events in PerfEventIsolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43358/#review118742 --- Patch looks great! Reviews applied: [43358] Passed command:

Re: Review Request 43358: Added support for all additional Perf Events in PerfEventIsolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43358/ --- (Updated Feb. 10, 2016, 12:39 p.m.) Review request for mesos, Ben Mahler, Chi

Re: Review Request 43358: Added support for all additional Perf Events in PerfEventIsolator.

> On Feb. 10, 2016, 1:54 a.m., haosdent huang wrote: > > src/linux/perf.cpp, line 471 > > > > > > How about move `` and `` out in a const > > variable? So that avoid we write these strings again and agiain. +1,

Re: Review Request 43358: Added support for all additional Perf Events in PerfEventIsolator.

> On Feb. 10, 2016, 1:54 a.m., haosdent huang wrote: > > src/linux/perf.cpp, line 493 > > > > > > should be better use `0u` here? Refer to bernd's patch > > https://reviews.apache.org/r/43359/diff/1#index_header to

Re: Review Request 43358: Added support for all additional Perf Events in PerfEventIsolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43358/ --- (Updated Feb. 10, 2016, 12:38 p.m.) Review request for mesos, Ben Mahler, Chi

Re: Review Request 43358: Added support for all additional Perf Events in PerfEventIsolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43358/#review118389 --- Patch looks great! Reviews applied: [43358] Passed command:

Re: Review Request 43358: Added support for all additional Perf Events in PerfEventIsolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43358/ --- (Updated Feb. 9, 2016, 12:54 p.m.) Review request for mesos, Ben Mahler, Chi

Re: Review Request 43358: Added support for all additional Perf Events in PerfEventIsolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43358/ --- (Updated Feb. 9, 2016, 12:47 p.m.) Review request for mesos, Ben Mahler, Chi

Re: Review Request 43358: Added support for all additional Perf Events in PerfEventIsolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43358/ --- (Updated Feb. 9, 2016, 12:47 p.m.) Review request for mesos, Ben Mahler, Chi

Re: Review Request 43358: Added support for all additional Perf Events in PerfEventIsolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43358/#review118546 --- Fix it, then Ship it! Ship It! src/linux/perf.cpp (line 466)