Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

2016-03-19 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43629/#review123863 --- Ship it! src/tests/fetcher_cache_tests.cpp (lines 165 - 167)

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

2016-03-18 Thread Joseph Wu
> On March 16, 2016, 5:48 a.m., Michael Park wrote: > > src/tests/fetcher_cache_tests.cpp, lines 167-169 > > > > > > Could you explain this NOTE? It looks like we do `fetcherProcess = new > > MockFetcherProcess();`

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

2016-03-15 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43629/ --- (Updated March 15, 2016, 1:48 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

2016-03-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43629/ --- (Updated March 14, 2016, 2:32 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

2016-03-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43629/ --- (Updated March 10, 2016, 12:28 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

2016-03-08 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43629/#review122504 --- Ship it! Ship It! - Bernd Mathiske On March 4, 2016, 3:55

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

2016-03-08 Thread Bernd Mathiske
> On March 3, 2016, 5:55 a.m., Bernd Mathiske wrote: > > src/tests/slave_recovery_tests.cpp, line 3461 > > > > > > Why was this moved up here? Couldn't this be in line 3389/3402? > > Joseph Wu wrote: > In this

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

2016-03-04 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43629/ --- (Updated March 4, 2016, 3:55 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

2016-03-04 Thread Joseph Wu
> On March 3, 2016, 5:55 a.m., Bernd Mathiske wrote: > > src/tests/slave_recovery_tests.cpp, line 3461 > > > > > > Why was this moved up here? Couldn't this be in line 3389/3402? > > Joseph Wu wrote: > In this

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

2016-03-04 Thread Bernd Mathiske
> On March 3, 2016, 5:55 a.m., Bernd Mathiske wrote: > > src/tests/slave_recovery_tests.cpp, line 3461 > > > > > > Why was this moved up here? Couldn't this be in line 3389/3402? > > Joseph Wu wrote: > In this

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

2016-03-03 Thread Joseph Wu
> On March 3, 2016, 5:55 a.m., Bernd Mathiske wrote: > > src/tests/slave_recovery_tests.cpp, line 3461 > > > > > > Why was this moved up here? Couldn't this be in line 3389/3402? In this case, it's because all

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

2016-03-03 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43629/#review121854 --- src/tests/slave_recovery_tests.cpp (line 3342)

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

2016-03-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43629/ --- (Updated March 2, 2016, 1:45 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

2016-02-29 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43629/ --- (Updated Feb. 29, 2016, 1:32 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

2016-02-22 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43629/ --- (Updated Feb. 22, 2016, 12:22 p.m.) Review request for mesos, Bernd Mathiske