Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/#review167391 --- Closing this review due to inactivity. Please see our

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

> On April 27, 2016, 9:17 p.m., Benjamin Mahler wrote: > > The `messages_*` metrics were originally added to track the number of each > > message type received by the master in the old libprocess message-passing > > API: > >

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/#review130842 --- The `messages_*` metrics were originally added to track the

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/#review125237 --- Patch looks great! Reviews applied: [44255] Passed command:

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/ --- (Updated 三月 24, 2016, 1:54 a.m.) Review request for mesos, Greg Mann, Guangya

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/#review124860 --- Patch looks great! Reviews applied: [44255] Passed command:

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/#review124811 --- Fix it, then Ship it! src/master/master.cpp (line 3028)

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/ --- (Updated 三月 14, 2016, 5:50 a.m.) Review request for mesos, Greg Mann, Guangya

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

> On 三月 12, 2016, 2:11 a.m., Greg Mann wrote: > > src/master/http.cpp, line 787 > > > > > > This increment statement occurs after some invalidation logic, and > > directly before the authorization call; is this

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

On March 12, 2016, 2:11 a.m., fan du wrote: > > In a separate patch, could you add documentation for these metrics to > > docs/monitoring.md? Whoops, sorry! I see that you already have the documentation :-) - Greg --- This is an

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/#review123247 --- Thanks for the edits! A few comments below.

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/#review122881 --- Patch looks great! Reviews applied: [44255] Passed command:

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

> On 三月 7, 2016, 10:43 p.m., Jie Yu wrote: > > src/master/master.cpp, line 2846 > > > > > > I looked weird to me that we increase the metrics for reserve resources > > in 'authorizeXXX' function. Can you do that

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/ --- (Updated 三月 10, 2016, 2:42 a.m.) Review request for mesos, Greg Mann, Guangya

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

> On March 7, 2016, 10:43 p.m., Jie Yu wrote: > > src/master/master.cpp, line 2846 > > > > > > I looked weird to me that we increase the metrics for reserve resources > > in 'authorizeXXX' function. Can you do

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

> On March 7, 2016, 10:43 p.m., Jie Yu wrote: > > src/master/master.cpp, line 2846 > > > > > > I looked weird to me that we increase the metrics for reserve resources > > in 'authorizeXXX' function. Can you do

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/#review122396 --- src/master/master.cpp (line 2846)

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/#review121913 --- Ship it! Ship It! - Greg Mann On March 3, 2016, 5:40 a.m.,

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

> On 三月 2, 2016, 7:40 p.m., Greg Mann wrote: > > Thanks Fan! I'm having a look at this now. Regarding the problems with > > review board not wanting to update your previous RR, it's probably because > > it didn't find the review URL in the commit message. In order to determine > > which RR it

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/ --- (Updated 三月 3, 2016, 5:40 a.m.) Review request for mesos, Greg Mann, Guangya

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/#review121707 --- Looks good! A couple small comments. docs/monitoring.md (line

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/#review121705 --- Thanks Fan! I'm having a look at this now. Regarding the problems

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/#review121619 --- Bad patch! Reviews applied: [44255] Failed command:

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/ --- (Updated 三月 2, 2016, 5:18 a.m.) Review request for mesos, Greg Mann, Guangya