Re: Review Request 44266: Rename event_call_framework.cpp to test_http_framework.cpp.

2016-03-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44266/#review121948 --- Ship it! The ReviewBot failure is unrelated (see

Re: Review Request 44266: Rename event_call_framework.cpp to test_http_framework.cpp.

2016-03-02 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44266/ --- (Updated March 3, 2016, 6:49 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 44266: Rename event_call_framework.cpp to test_http_framework.cpp.

2016-03-02 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44266/#review121789 --- src/tests/event_call_framework_test.sh (line 42)

Re: Review Request 44266: Rename event_call_framework.cpp to test_http_framework.cpp.

2016-03-02 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44266/#review121788 --- Fix it, then Ship it! src/tests/examples_tests.cpp (line 27)

Re: Review Request 44266: Rename event_call_framework.cpp to test_http_framework.cpp.

2016-03-02 Thread Yong Tang
> On March 3, 2016, 1 a.m., Vinod Kone wrote: > > Looks great. > > > > Can you also rename the class name in test_http_framework.cpp? > > s/EventCallScheduler/HTTPScheduler/ > > Yong Tang wrote: > Thanks Vinod. Will update the review request shortly. Just updated the review request. Let

Re: Review Request 44266: Rename event_call_framework.cpp to test_http_framework.cpp.

2016-03-02 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44266/ --- (Updated March 3, 2016, 4:27 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 44266: Rename event_call_framework.cpp to test_http_framework.cpp.

2016-03-02 Thread Yong Tang
> On March 3, 2016, 1 a.m., Vinod Kone wrote: > > Looks great. > > > > Can you also rename the class name in test_http_framework.cpp? > > s/EventCallScheduler/HTTPScheduler/ Thanks Vinod. Will update the review request shortly. - Yong

Re: Review Request 44266: Rename event_call_framework.cpp to test_http_framework.cpp.

2016-03-02 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44266/#review121753 --- Looks great. Can you also rename the class name in

Re: Review Request 44266: Rename event_call_framework.cpp to test_http_framework.cpp.

2016-03-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44266/#review121670 --- Patch looks great! Reviews applied: [44266] Passed command: