Re: Review Request 44650: Omitted names of unused parameters in executor library.

2016-03-15 Thread Alexander Rukletsov
> On March 15, 2016, 3:18 a.m., Ben Mahler wrote: > > src/exec/exec.cpp, line 206 > > > > > > This doesn't seem like the style we use for unused arguments..? > > Joerg Schad wrote: > There are examples for this

Re: Review Request 44650: Omitted names of unused parameters in executor library.

2016-03-15 Thread Joerg Schad
> On March 15, 2016, 3:18 a.m., Ben Mahler wrote: > > src/exec/exec.cpp, line 206 > > > > > > This doesn't seem like the style we use for unused arguments..? There are examples for this in the codebase (see

Re: Review Request 44650: Omitted names of unused parameters in executor library.

2016-03-14 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44650/#review123587 --- src/exec/exec.cpp (line 206)

Re: Review Request 44650: Omitted names of unused parameters in executor library.

2016-03-14 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44650/ --- (Updated March 14, 2016, 5:45 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 44650: Omitted names of unused parameters in executor library.

2016-03-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44650/ --- (Updated March 11, 2016, 4 p.m.) Review request for mesos, Ben Mahler and