Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

> On May 17, 2016, 1:27 p.m., haosdent huang wrote: > > src/Makefile.am, line 2048 > > > > > > I think you forgot to update the CMake build files. > > Qian Zhang wrote: > I see all the tests are not included

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46097/#review134442 --- Ship it! Ship It! - Jie Yu On May 12, 2016, 8:11 a.m., Qian

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

> On May 17, 2016, 9:27 p.m., haosdent huang wrote: > > src/Makefile.am, line 2048 > > > > > > I think you forgot to update the CMake build files. I see all the tests are not included in `src/CMakeLists.txt`, so

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46097/#review133530 --- src/Makefile.am (line 2048)

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46097/ --- (Updated May 12, 2016, 4:11 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

> On May 6, 2016, 5:34 p.m., Jie Yu wrote: > > src/tests/containerizer/cni_isolator_tests.cpp, line 42 > > > > > > Instead of using a script here, can we use code to get ip network and > > name server information? >

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

> On May 7, 2016, 1:34 a.m., Jie Yu wrote: > > src/tests/containerizer/cni_isolator_tests.cpp, line 42 > > > > > > Instead of using a script here, can we use code to get ip network and > > name server information? >

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

> On May 7, 2016, 1:34 a.m., Jie Yu wrote: > > src/tests/containerizer/cni_isolator_tests.cpp, line 42 > > > > > > Instead of using a script here, can we use code to get ip network and > > name server information? >

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46097/#review132084 --- src/tests/containerizer/cni_isolator_tests.cpp (line 42)

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

> On May 6, 2016, 5:29 a.m., Jie Yu wrote: > > This test failed on my machine: > > > > ``` > > E0505 14:28:48.309273 42478 slave.cpp:3995] Container > > '33dc5d83-125f-4da2-8c69-cba76d95955b' for executor > > '0e6076e9-9cc3-4319-aacd-6b6bb8651e9b' of framework > >

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46097/ --- (Updated May 6, 2016, 10:06 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

> On May 6, 2016, 5:29 a.m., Jie Yu wrote: > > This test failed on my machine: > > > > ``` > > E0505 14:28:48.309273 42478 slave.cpp:3995] Container > > '33dc5d83-125f-4da2-8c69-cba76d95955b' for executor > > '0e6076e9-9cc3-4319-aacd-6b6bb8651e9b' of framework > >

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

> On May 5, 2016, 9:29 p.m., Jie Yu wrote: > > This test failed on my machine: > > > > ``` > > E0505 14:28:48.309273 42478 slave.cpp:3995] Container > > '33dc5d83-125f-4da2-8c69-cba76d95955b' for executor > > '0e6076e9-9cc3-4319-aacd-6b6bb8651e9b' of framework > >

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46097/#review131937 --- This test failed on my machine: ``` E0505 14:28:48.309273 42478

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46097/#review131933 --- src/tests/containerizer/cni_isolator_tests.cpp (line 53)

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

> On May 4, 2016, 11:44 p.m., Jie Yu wrote: > > src/tests/containerizer/cni_isolator_tests.cpp, line 31 > > > > > > No need for `#ifdef __linux__` because the file is guarded by `if > > OS_LINUX` in makefile. > >

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46097/ --- (Updated May 5, 2016, 10:29 p.m.) Review request for mesos, Avinash sridharan

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

> On May 5, 2016, 7:44 a.m., Jie Yu wrote: > > src/tests/containerizer/cni_isolator_tests.cpp, line 31 > > > > > > No need for `#ifdef __linux__` because the file is guarded by `if > > OS_LINUX` in makefile. OK.

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46097/ --- (Updated April 26, 2016, 11:53 p.m.) Review request for mesos, Avinash

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

> On April 22, 2016, 5:19 a.m., Avinash sridharan wrote: > > src/tests/containerizer/cni_isolator_tests.cpp, line 24 > > > > > > I think `mesos` definitions should come after `process`. No, I think we should do it

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46097/#review129957 --- src/tests/containerizer/cni_isolator_tests.cpp (line 20)

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46097/ --- (Updated April 20, 2016, 10:26 p.m.) Review request for mesos, Avinash

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46097/ --- (Updated April 20, 2016, 9:47 p.m.) Review request for mesos, Avinash

Re: Review Request 46097: Added the test "CniIsolatorTest.ROOT_LaunchCommandTask".

> On April 13, 2016, 12:07 a.m., Avinash sridharan wrote: > > src/tests/containerizer/cni_isolator_tests.cpp, line 143 > > > > > > Can we make the task long running, and then check that the CNI network > >