Re: Review Request 49913: Moved createFrameworkInfo() function definition to tests/mesos.hpp.

2016-07-19 Thread Abhishek Dasgupta
> On July 19, 2016, 12:49 a.m., Vinod Kone wrote: > > src/tests/mesos.hpp, lines 610-615 > > > > > > I think a generic `createFrameworkInfo()` that returns > > DEFAULT_FRAMEWORK_INFO with "role1" is unintuitive for

Re: Review Request 49913: Moved createFrameworkInfo() function definition to tests/mesos.hpp.

2016-07-19 Thread Abhishek Dasgupta
> On July 19, 2016, 12:49 a.m., Vinod Kone wrote: > > src/tests/mesos.hpp, lines 610-615 > > > > > > I think a generic `createFrameworkInfo()` that returns > > DEFAULT_FRAMEWORK_INFO with "role1" is unintuitive for

Re: Review Request 49913: Moved createFrameworkInfo() function definition to tests/mesos.hpp.

2016-07-18 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49913/#review142672 --- src/tests/mesos.hpp (lines 610 - 615)

Re: Review Request 49913: Moved createFrameworkInfo() function definition to tests/mesos.hpp.

2016-07-18 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49913/ --- (Updated July 18, 2016, 8:11 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49913: Moved createFrameworkInfo() function definition to tests/mesos.hpp.

2016-07-15 Thread Jay Guo
> On July 12, 2016, 2:24 a.m., Jay Guo wrote: > > src/tests/mesos.hpp, line 582 > > > > > > why `role1` but not `role`? > > Abhishek Dasgupta wrote: > There are three reasons for this: > > 1. Renaming

Re: Review Request 49913: Moved createFrameworkInfo() function definition to tests/mesos.hpp.

2016-07-15 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49913/ --- (Updated July 15, 2016, 11:08 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49913: Moved createFrameworkInfo() function definition to tests/mesos.hpp.

2016-07-15 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49913/ --- (Updated July 15, 2016, 11:07 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49913: Moved createFrameworkInfo() function definition to tests/mesos.hpp.

2016-07-15 Thread Abhishek Dasgupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49913/ --- (Updated July 15, 2016, 10:47 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49913: Moved createFrameworkInfo() function definition to tests/mesos.hpp.

2016-07-12 Thread Abhishek Dasgupta
> On July 12, 2016, 2:24 a.m., Jay Guo wrote: > > src/tests/mesos.hpp, line 582 > > > > > > why `role1` but not `role`? There are three reasons for this: 1. Renaming to role instead of role1 needs more changes in

Re: Review Request 49913: Moved createFrameworkInfo() function definition to tests/mesos.hpp.

2016-07-11 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49913/#review141832 --- src/tests/mesos.hpp (line 582)