Re: Review Request 52620: Updated InverseOffers* maintenance tests to use the new scheduler mock.

2016-10-10 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52620/#review152054 --- Ship it! LGTM - Anand Mazumdar On Oct. 10, 2016, 7:18 p.m.,

Re: Review Request 52620: Updated InverseOffers* maintenance tests to use the new scheduler mock.

2016-10-10 Thread Ilya Pronin
> On Oct. 7, 2016, 11:51 p.m., Anand Mazumdar wrote: > > src/tests/master_maintenance_tests.cpp, lines 1169-1171 > > > > > > We prefer to keep expectations close to the actual business logic for > > readability.

Re: Review Request 52620: Updated InverseOffers* maintenance tests to use the new scheduler mock.

2016-10-10 Thread Ilya Pronin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52620/ --- (Updated Oct. 10, 2016, 8:18 p.m.) Review request for mesos and Anand

Re: Review Request 52620: Updated InverseOffers* maintenance tests to use the new scheduler mock.

2016-10-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52620/#review151923 --- Patch looks great! Reviews applied: [52620] Passed command:

Re: Review Request 52620: Updated InverseOffers* maintenance tests to use the new scheduler mock.

2016-10-07 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52620/#review151890 --- Thanks Ilya. Looks pretty good! - Mostly minor comments around

Re: Review Request 52620: Updated InverseOffers* maintenance tests to use the new scheduler mock.

2016-10-07 Thread Ilya Pronin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52620/ --- (Updated Oct. 7, 2016, 6:29 p.m.) Review request for mesos and Anand Mazumdar.