Re: Review Request 53386: Fixed memory leak in JVM code.

2016-11-04 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53386/#review154993 --- Ship it! LGTM! - Joseph Wu On Nov. 3, 2016, 8:31 a.m., Neil

Re: Review Request 53386: Fixed memory leak in JVM code.

2016-11-03 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53386/ --- (Updated Nov. 3, 2016, 3:31 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 53386: Fixed memory leak in JVM code.

2016-11-03 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53386/#review154686 --- src/jvm/jvm.cpp (line 95)

Re: Review Request 53386: Fixed memory leak in JVM code.

2016-11-02 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53386/ --- (Updated Nov. 2, 2016, 11:56 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 53386: Fixed memory leak in JVM code.

2016-11-02 Thread Benjamin Bannier
> On Nov. 2, 2016, 5:39 p.m., Benjamin Bannier wrote: > > src/jvm/jvm.cpp, lines 97-102 > > > > > > This will work as long nobody adds new `return` statements before the > > corresponding `delete`. > > > >

Re: Review Request 53386: Fixed memory leak in JVM code.

2016-11-02 Thread Neil Conway
> On Nov. 2, 2016, 4:39 p.m., Benjamin Bannier wrote: > > src/jvm/jvm.cpp, lines 97-102 > > > > > > This will work as long nobody adds new `return` statements before the > > corresponding `delete`. > > > >

Re: Review Request 53386: Fixed memory leak in JVM code.

2016-11-02 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53386/#review154578 --- src/jvm/jvm.cpp (lines 90 - 95)