Re: Review Request 54349: Added os::dup2 to stout.

2016-12-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54349/ --- (Updated Dec. 5, 2016, 5:36 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 54349: Added os::dup2 to stout.

2016-12-04 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54349/#review157949 --- Ship it! Ship It! - Benjamin Hindman On Dec. 4, 2016, 9:17

Re: Review Request 54349: Added os::dup2 to stout.

2016-12-04 Thread Jie Yu
> On Dec. 5, 2016, 1:02 a.m., Kevin Klues wrote: > > Should we add an equivalent function for windows? I assume we will need one > > to make any child hooks we add to `Subprocess` cross platform. dup is posix specific. i think we will have posix specific hooks anyway (e.g., supervised and

Re: Review Request 54349: Added os::dup2 to stout.

2016-12-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54349/#review157934 --- Ship it! Should we add an equivalent function for windows? I