Re: Review Request 55191: Add hostname support to the network/cni isolator.

> On Jan. 18, 2017, 11:02 a.m., Jie Yu wrote: > > src/tests/containerizer/cni_isolator_tests.cpp, line 288 > > > > > > I don't like the idea of piggybacking on this test. I'll probably > > create a new one. I

Re: Review Request 55191: Add hostname support to the network/cni isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55191/#review162058 --- src/slave/containerizer/mesos/isolators/network/cni/cni.hpp

Re: Review Request 55191: Add hostname support to the network/cni isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55191/#review162042 --- Patch looks great! Reviews applied: [55191] Passed command:

Re: Review Request 55191: Add hostname support to the network/cni isolator.

> On Jan. 6, 2017, 6:58 p.m., Jie Yu wrote: > > i feel that we can write a unit test using `__MESOS_TEST__`, can't we? > > Avinash sridharan wrote: > Actually you are right. Didn't realize we are actually setting up a new > UTS name space for __MESOS_TEST__ > >

Re: Review Request 55191: Add hostname support to the network/cni isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55191/ --- (Updated Jan. 18, 2017, 12:54 a.m.) Review request for mesos, Avinash

Re: Review Request 55191: Add hostname support to the network/cni isolator.

> On Jan. 6, 2017, 6:58 p.m., Jie Yu wrote: > > i feel that we can write a unit test using `__MESOS_TEST__`, can't we? Actually you are right. Didn't realize we are actually setting up a new UTS name space for __MESOS_TEST__

Re: Review Request 55191: Add hostname support to the network/cni isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55191/#review160729 --- Fix it, then Ship it! i feel that we can write a unit test

Re: Review Request 55191: Add hostname support to the network/cni isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55191/#review160721 --- Patch looks great! Reviews applied: [55191] Passed command:

Re: Review Request 55191: Add hostname support to the network/cni isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55191/#review160689 --- Fix it, then Ship it!

Re: Review Request 55191: Add hostname support to the network/cni isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55191/ --- (Updated Jan. 5, 2017, 5:04 p.m.) Review request for mesos, Avinash sridharan,

Re: Review Request 55191: Add hostname support to the network/cni isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55191/#review160553 --- Ship it! Thanks for taking this on. Looks good. Can you run