Re: Review Request 55313: Windows: Fixed the unkillable task bug, lit up executor tests.

2017-01-18 Thread Alex Clemmer
> On Jan. 18, 2017, 11:04 p.m., Joseph Wu wrote: > > src/tests/default_executor_tests.cpp, lines 442-444 > > > > > > Here too. Oh, shoot, sorry. I should have caught that. - Alex

Re: Review Request 55313: Windows: Fixed the unkillable task bug, lit up executor tests.

2017-01-18 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55313/#review162202 --- Ship it! Ship It! - Joseph Wu On Jan. 18, 2017, 12:49 p.m.,

Re: Review Request 55313: Windows: Fixed the unkillable task bug, lit up executor tests.

2017-01-18 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55313/#review162200 --- src/tests/command_executor_tests.cpp (lines 425 - 427)

Re: Review Request 55313: Windows: Fixed the unkillable task bug, lit up executor tests.

2017-01-18 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55313/ --- (Updated Jan. 18, 2017, 8:49 p.m.) Review request for mesos, Andrew

Re: Review Request 55313: Windows: Fixed the unkillable task bug, lit up executor tests.

2017-01-18 Thread Alex Clemmer
> On Jan. 18, 2017, 2:08 a.m., Joseph Wu wrote: > > src/slave/containerizer/mesos/launcher.cpp, lines 117-133 > > > > > > I suspect that we'll use this lambda for other subprocesses in future, > > so let's move it

Re: Review Request 55313: Windows: Fixed the unkillable task bug, lit up executor tests.

2017-01-17 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55313/#review162016 --- src/slave/containerizer/mesos/launcher.cpp (lines 117 - 133)