Re: Review Request 56474: Added support for multiple authenticators to libprocess.

2017-03-09 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56474/ --- (Updated March 9, 2017, 11:40 p.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 56474: Added support for multiple authenticators to libprocess.

2017-03-01 Thread Greg Mann
> On Feb. 13, 2017, 3:01 p.m., Alexander Rojas wrote: > > So now I remembered why originally it didn't support multiple > > authenticators. In my original design I favored composition of > > authenticators, in facto, I think one of the first iteration of the patches > > included an

Re: Review Request 56474: Added support for multiple authenticators to libprocess.

2017-02-13 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56474/#review165328 --- So now I remembered why originally it didn't support multiple

Re: Review Request 56474: Added support for multiple authenticators to libprocess.

2017-02-13 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56474/#review165304 --- 3rdparty/libprocess/src/authenticator_manager.cpp (lines 77 -

Re: Review Request 56474: Added support for multiple authenticators to libprocess.

2017-02-10 Thread Greg Mann
> On Feb. 9, 2017, 3:03 p.m., Jan Schlicht wrote: > > 3rdparty/libprocess/src/authenticator_manager.cpp, lines 168-204 > > > > > > How about we make this a function instead of using a lambda? > > Seems to do a

Re: Review Request 56474: Added support for multiple authenticators to libprocess.

2017-02-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56474/ --- (Updated Feb. 11, 2017, 12:44 a.m.) Review request for mesos, Alexander Rojas,

Re: Review Request 56474: Added support for multiple authenticators to libprocess.

2017-02-09 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56474/#review164924 --- 3rdparty/libprocess/src/authenticator_manager.cpp (line 15)