Re: Review Request 60439: Added scripts to automate website publishing.

> On Aug. 2, 2017, 10:59 a.m., Benjamin Bannier wrote: > > support/mesos-website/entrypoint.sh > > Lines 23 (patched) > > > > > > Do you still recall why this was needed? It would be great to add e.g., > > a JIRA or

Re: Review Request 60439: Added scripts to automate website publishing.

> On Aug. 2, 2017, 10:52 a.m., Benjamin Bannier wrote: > > support/mesos-website/build.sh > > Lines 22 (patched) > > > > > > This script will misbehave if run from a live dev checkout (it might > > e.g., reconfigure

Re: Review Request 60439: Added scripts to automate website publishing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60439/#review182220 --- Ship it! Ship It! - Benjamin Bannier On Aug. 4, 2017, 8:36

Re: Review Request 60439: Added scripts to automate website publishing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60439/ --- (Updated Aug. 4, 2017, 6:36 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 60439: Added scripts to automate website publishing.

> On Aug. 2, 2017, 8:59 a.m., Benjamin Bannier wrote: > > support/mesos-website/entrypoint.sh > > Lines 23 (patched) > > > > > > Do you still recall why this was needed? It would be great to add e.g., > > a JIRA or

Re: Review Request 60439: Added scripts to automate website publishing.

> On Aug. 2, 2017, 8:52 a.m., Benjamin Bannier wrote: > > support/mesos-website/build.sh > > Lines 22 (patched) > > > > > > This script will misbehave if run from a live dev checkout (it might > > e.g., reconfigure

Re: Review Request 60439: Added scripts to automate website publishing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60439/#review181956 --- support/mesos-website/Dockerfile Lines 13 (patched)

Re: Review Request 60439: Added scripts to automate website publishing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60439/#review181951 --- support/mesos-website/entrypoint.sh Lines 23 (patched)

Re: Review Request 60439: Added scripts to automate website publishing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60439/#review181942 --- support/mesos-website.sh Lines 29 (patched)

Re: Review Request 60439: Added scripts to automate website publishing.

> On July 3, 2017, 4:47 p.m., haosdent huang wrote: > > support/mesos-website/entrypoint.sh > > Lines 32 (patched) > > > > > > Is it OK to run support/mesos-website/build.sh as root? looks like you answered yourself

Re: Review Request 60439: Added scripts to automate website publishing.

> On July 3, 2017, 5:11 p.m., haosdent huang wrote: > > Really sorry for the delay. LGTM, just want to sure is it possible to merge > > build.sh into entrypoint.sh We need to keep this separate because build.sh needs to be run as non-root user, whereas entrypoint.sh need to be run as root

Re: Review Request 60439: Added scripts to automate website publishing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60439/ --- (Updated July 27, 2017, 12:28 a.m.) Review request for mesos, Benjamin

Re: Review Request 60439: Added scripts to automate website publishing.

> On July 4, 2017, 12:02 p.m., Benjamin Bannier wrote: > > This is a great start, but I would prefer if we wouldn't directly mount an > > existing source directory into the container and bootstrap, configure and > > build in it (this is also broken for e.g., in-source builds). > > > > What

Re: Review Request 60439: Added scripts to automate website publishing.

> On July 3, 2017, 4:51 p.m., haosdent huang wrote: > > support/mesos-website/build.sh > > Lines 42-43 (patched) > > > > > > Should we move `bundle install` to here? No. As commented in entrypoint.sh, `bundle

Re: Review Request 60439: Added scripts to automate website publishing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60439/#review179310 --- This is a great start, but I would prefer if we wouldn't directly

Re: Review Request 60439: Added scripts to automate website publishing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60439/#review179523 --- Really sorry for the delay. LGTM, just want to sure is it

Re: Review Request 60439: Added scripts to automate website publishing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60439/#review179518 --- support/mesos-website/entrypoint.sh Lines 32 (patched)

Re: Review Request 60439: Added scripts to automate website publishing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60439/#review179517 --- support/mesos-website/build.sh Lines 42-43 (patched)

Re: Review Request 60439: Added scripts to automate website publishing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60439/#review179515 --- support/mesos-website/entrypoint.sh Lines 32 (patched)