Re: Review Request 60624: Enabled HDFS compilation and associated tests.

2017-12-08 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60624/#review193294 --- Ship it! Ship It! - Andrew Schwartzmeyer On Dec. 7, 2017,

Re: Review Request 60624: Enabled HDFS compilation and associated tests.

2017-12-07 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60624/ --- (Updated Dec. 8, 2017, 2:44 a.m.) Review request for mesos, Andrew

Re: Review Request 60624: Enabled HDFS compilation and associated tests.

2017-11-16 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60624/#review191202 --- Fix it, then Ship it! src/tests/hdfs_tests.cpp Lines 55

Re: Review Request 60624: Enabled HDFS compilation and associated tests.

2017-10-19 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60624/ --- (Updated Oct. 19, 2017, 9:33 p.m.) Review request for mesos, Andrew

Re: Review Request 60624: Enabled HDFS compilation and associated tests.

2017-10-19 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60624/#review188762 --- Ship it! Ship It! - Andrew Schwartzmeyer On Oct. 19, 2017,

Re: Review Request 60624: Enabled HDFS compilation and associated tests.

2017-10-19 Thread Jeff Coffler
> On Oct. 17, 2017, 11:24 p.m., Andrew Schwartzmeyer wrote: > > src/tests/hdfs_tests.cpp > > Lines 55-57 (original), 55-60 (patched) > > > > > > Nit: this comment isn't great... we do know how to handle execution >

Re: Review Request 60624: Enabled HDFS compilation and associated tests.

2017-10-19 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60624/ --- (Updated Oct. 19, 2017, 6:18 p.m.) Review request for mesos, Andrew

Re: Review Request 60624: Enabled HDFS compilation and associated tests.

2017-10-17 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60624/#review188418 --- src/tests/hdfs_tests.cpp Lines 55-57 (original), 55-60 (patched)

Re: Review Request 60624: Enabled HDFS compilation and associated tests.

2017-10-16 Thread Jeff Coffler
> On Oct. 13, 2017, 7:20 p.m., Andrew Schwartzmeyer wrote: > > src/launcher/fetcher.cpp > > Lines 267-272 (original), 267-275 (patched) > > > > > > The changes to `fetcher.cpp` shouldn't be in this review, please

Re: Review Request 60624: Enabled HDFS compilation and associated tests.

2017-10-16 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60624/ --- (Updated Oct. 17, 2017, 1:18 a.m.) Review request for mesos, Andrew

Re: Review Request 60624: Enabled HDFS compilation and associated tests.

2017-10-13 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60624/#review188002 --- This review should be combined with #60626.

Re: Review Request 60624: Enabled HDFS compilation and associated tests.

2017-10-12 Thread Jeff Coffler
> On Oct. 8, 2017, 2:23 a.m., Andrew Schwartzmeyer wrote: > > What is the reason that the HDFS files are now made to build on Windows, > > but (AFAICT) not actually enabled for support? Is there an immediate plan > > to support HDFS, and if not, why start building the files? HDFS should work,

Re: Review Request 60624: Enabled HDFS compilation and associated tests.

2017-10-11 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60624/ --- (Updated Oct. 11, 2017, 11:32 p.m.) Review request for mesos, Andrew