Re: Review Request 60820: Added class definition for SlaveID, ContainerID acceptors.

2017-07-18 Thread Quinn Leng
> On July 18, 2017, 5:54 p.m., Alexander Rojas wrote: > > src/common/http.hpp > > Lines 205 (patched) > > > > > > Why are these default constructors necesary? It used to be necessary because we were trying to get

Re: Review Request 60820: Added class definition for SlaveID, ContainerID acceptors.

2017-07-18 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60820/#review180833 --- Could you reword the commit message with a little bit more of

Re: Review Request 60820: Added class definition for SlaveID, ContainerID acceptors.

2017-07-18 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60820/#review180821 --- src/common/http.hpp Lines 197-198 (original), 197-211 (patched)

Re: Review Request 60820: Added class definition for SlaveID, ContainerID acceptors.

2017-07-13 Thread Quinn Leng
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60820/ --- (Updated July 14, 2017, 12:10 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 60820: Added class definition for SlaveID, ContainerID acceptors.

2017-07-13 Thread Quinn Leng
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60820/#review180465 --- src/common/http.hpp Lines 204-205 (patched)

Re: Review Request 60820: Added class definition for SlaveID, ContainerID acceptors.

2017-07-13 Thread Quinn Leng
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60820/ --- (Updated July 13, 2017, 8:23 p.m.) Review request for mesos, Anand Mazumdar,