Re: Review Request 60902: Moved the libnl3 configure checks into a macro.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60902/#review183440 --- Ship it! Ship It! - Jie Yu On July 16, 2017, 11:43 p.m.,

Re: Review Request 60902: Moved the libnl3 configure checks into a macro.

> On July 17, 2017, 11:20 a.m., Qian Zhang wrote: > > m4/libnl3.m4 > > Lines 33-37 (patched) > > > > > > Mind to elaborate a bit about why introducing a new .m4 file? What > > about just introducing a new configure

Re: Review Request 60902: Moved the libnl3 configure checks into a macro.

> On July 17, 2017, 3:20 a.m., Qian Zhang wrote: > > m4/libnl3.m4 > > Lines 33-37 (patched) > > > > > > Mind to elaborate a bit about why introducing a new .m4 file? What > > about just introducing a new configure

Re: Review Request 60902: Moved the libnl3 configure checks into a macro.

> On July 17, 2017, 11:20 a.m., Qian Zhang wrote: > > m4/libnl3.m4 > > Lines 33-37 (patched) > > > > > > Mind to elaborate a bit about why introducing a new .m4 file? What > > about just introducing a new configure

Re: Review Request 60902: Moved the libnl3 configure checks into a macro.

> On July 17, 2017, 3:20 a.m., Qian Zhang wrote: > > m4/libnl3.m4 > > Lines 33-37 (patched) > > > > > > Mind to elaborate a bit about why introducing a new .m4 file? What > > about just introducing a new configure

Re: Review Request 60902: Moved the libnl3 configure checks into a macro.

> On July 17, 2017, 11:20 a.m., Qian Zhang wrote: > > m4/libnl3.m4 > > Lines 33-37 (patched) > > > > > > Mind to elaborate a bit about why introducing a new .m4 file? What > > about just introducing a new configure

Re: Review Request 60902: Moved the libnl3 configure checks into a macro.

> On July 17, 2017, 5:14 a.m., Qian Zhang wrote: > > Do we need to change anything in CMake side? No, this isn't implemented in the CMake build. - James --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 60902: Moved the libnl3 configure checks into a macro.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60902/#review180655 --- Do we need to change anything in CMake side? - Qian Zhang On

Re: Review Request 60902: Moved the libnl3 configure checks into a macro.

> On July 17, 2017, 3:20 a.m., Qian Zhang wrote: > > configure.ac > > Line 350 (original) > > > > > > So `--with-nl` is removed, will it cause backward compatibility issue? No, `--with-nl` is provided by the

Re: Review Request 60902: Moved the libnl3 configure checks into a macro.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60902/#review180653 --- configure.ac Line 350 (original)