Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/ --- (Updated Feb. 7, 2018, 3:13 p.m.) Review request for mesos, Armand Grillet,

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review196992 --- Ship it! Ship It! - Kevin Klues On Jan. 19, 2018, 8:48

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review196638 --- Ship it! Ship It! - Armand Grillet On Jan. 19, 2018, 8:48

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review195852 --- PASS: Mesos patch 61172 was successfully built and tested.

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

> On Jan. 18, 2018, 1:59 p.m., Kevin Klues wrote: > > src/python/lib/mesos/exceptions.py > > Lines 27-33 (patched) > > > > > > I would prefer to do this at each call site instead of wrapping it up > > and hiding

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/ --- (Updated Jan. 19, 2018, 8:48 p.m.) Review request for mesos, Armand Grillet,

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review195718 --- src/python/lib/mesos/exceptions.py Lines 27-33 (patched)

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review195690 --- PASS: Mesos patch 61172 was successfully built and tested.

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/ --- (Updated Jan. 18, 2018, 4:25 a.m.) Review request for mesos, Armand Grillet,

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

> On Jan. 5, 2018, 3:23 p.m., Armand Grillet wrote: > > src/python/cli_new/bootstrap > > Lines 72 (patched) > > > > > > This file does not exist, is that normal? it should... ``` ~/mesos/src/python/lib$ git blame

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review194862 --- Some small issues to fix, there are also some typos in the commit

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review194604 --- src/python/lib/mesos/http.py Lines 149 (patched)

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/ --- (Updated Jan. 1, 2018, 1:52 a.m.) Review request for mesos, Armand Grillet,

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review193865 --- FAIL: Some Mesos tests failed. Reviews applied: `['61172']`

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review193850 --- src/python/lib/mesos/exceptions.py Lines 56 (patched)

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/ --- (Updated Nov. 30, 2017, 10:16 a.m.) Review request for mesos, Armand Grillet,

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review186830 --- Patch looks great! Reviews applied: [61172] Passed command:

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review186763 --- FAIL: Some Mesos tests failed. Reviews applied: `['61172']`

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/ --- (Updated Sept. 29, 2017, 9:25 p.m.) Review request for mesos, Armand Grillet,

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review186685 --- src/python/lib/mesos/exceptions.py Lines 21 (patched)

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review186680 --- Looks like this needs a rebase. I can't get it to apply cleanly.

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review185893 --- Patch looks great! Reviews applied: [61172] Passed command:

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review185876 --- PASS: Mesos patch 61172 was successfully built and tested.

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review185848 --- FAIL: Some Mesos tests failed. Reviews applied: `['61172']`

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/ --- (Updated Sept. 21, 2017, 4:27 a.m.) Review request for mesos, Armand Grillet,

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/ --- (Updated Sept. 21, 2017, 4:23 a.m.) Review request for mesos, Armand Grillet,

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review184295 --- src/python/lib/mesos/exceptions.py Lines 30 (patched)

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review183985 --- Patch looks great! Reviews applied: [61172] Passed command:

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review183980 --- Bad patch! Reviews applied: [61172] Logs available here:

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review183963 --- bump? - Eric Chung On Aug. 9, 2017, 5:54 p.m., Eric Chung

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/ --- (Updated Aug. 9, 2017, 5:54 p.m.) Review request for mesos, Armand Grillet,

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review182479 --- Ship it! Testing done: ``` install tox cd src/python/lib tox

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review182313 --- ping - Eric Chung On Aug. 3, 2017, 9:41 p.m., Eric Chung

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/ --- (Updated Aug. 3, 2017, 9:41 p.m.) Review request for mesos, Armand Grillet,

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/ --- (Updated Aug. 3, 2017, 9:41 p.m.) Review request for mesos, Armand Grillet,

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

> On July 29, 2017, 3:12 p.m., Armand Grillet wrote: > > src/python/lib/mesos/http.py > > Lines 119 (patched) > > > > > > Missing period, s/`verb`/`token` according to > >

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/ --- (Updated Aug. 3, 2017, 9:15 p.m.) Review request for mesos, Armand Grillet,

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/ --- (Updated Aug. 3, 2017, 9:15 p.m.) Review request for mesos, Armand Grillet,

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

> On July 29, 2017, 3:12 p.m., Armand Grillet wrote: > > src/python/lib/mesos/http.py > > Lines 33 (patched) > > > > > > We generally prefer to do one import per line but it would be quite > > heavy in that

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

> On July 29, 2017, 3:12 p.m., Armand Grillet wrote: > > In _testing done_, there seems to be a missing first part asking to run the > > updated bootstrap script and `source activate` under `src/python/cli_new` > > before running `tox`. At least these were necessary steps for me to have > >

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review181756 --- In _testing done_, there seems to be a missing first part asking

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review181537 --- Patch looks great! Reviews applied: [61172] Passed command:

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/ --- (Updated July 27, 2017, 7:09 a.m.) Review request for mesos, Armand Grillet,